Conversation
mdespuits
requested review from
dkordik,
nvmusoke,
pixelbandito and
sebastianvera
| integrity sha1-0CJTc662Uq3BvILklFM5qEJ1R3M= | ||
|
|
||
| "lodash@>=3.5 <5", lodash@^4.15.0, lodash@^4.17.11, lodash@^4.17.13, lodash@^4.17.14, lodash@^4.17.2, lodash@^4.17.3, lodash@^4.17.4, lodash@^4.3.0: | ||
| "lodash@>=3.5 <5", lodash@^4.15.0, lodash@^4.17.11, lodash@^4.17.13, lodash@^4.17.14, lodash@^4.17.15, lodash@^4.17.2, lodash@^4.17.3, lodash@^4.17.4, lodash@^4.3.0: |
There was a problem hiding this comment.
Guess we missed a yarn install on a previous deploy?
There was a problem hiding this comment.
Maybe? This is the example/yarn.lock which doesn't get updated as often
is there a debugging cost to this? inspecting an element no longer tells you what component is applying a style? |
|
@dkordik There may be, but 99% of the time active development on Rover will be using the webpack config which includes the name. For the rollup production build it makes sense to use smaller classnames and rely on Component name and CSS sourcemaps to keep the dependencies smaller |
This simplifies the CSS class name generation considerably. Instead
of `.styles__Avatar-{hash}` format, it now is simply `.rvr-{hash}`. Not
only does this clarify that this is a Rover class, but it shortens the
classname itself and shrinks the build output a bit
mdespuits
force-pushed
the
better-css-module-names
branch
from
849a4d7 to
d29b60e
Compare
4 participants
This simplifies the CSS class name generation considerably. Instead of
.styles__Avatar-{hash}format, it now is simply.rvr-{hash}. Not only does this clarify that this is a Rover class, but it shortens the classname itself and shrinks the build output a bit