TypeScript: Tests, CSS modules, and dependency updates#178
Merged
TypeScript: Tests, CSS modules, and dependency updates#178
Conversation
added 6 commits
May 21, 2020 20:09
Contributor
pixelbandito
left a comment
There was a problem hiding this comment.
This all looks very clean.
My only comment is it looks like 2 eslint rules that are stylistic only are causing a lot of small adjustments.
- In one case (parens around arrow function single arguments) I actually dislike the new rule.
- In the other case (space before parens in
function (), I don't really care but changing it seems pointless and causes a lot of nitpicky changes from what's currently there.
Otherwise, I see a lot of nice tweaks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it turns out, trying to convert existing components and their tests, etc to TypeScript is currently tricky with our outdated dependencies. One of the primary offenders was
react-scriptsitself. We were running on a 2 year old version. It was worth updating to the latest anyway since it has much better TypeScript support. This meant several things:react-scriptschanged the matcher for Jest tests. Needed to be*.(spec|test).(ts|js|jsx|tsx)or something along those linesreact-scriptswebpack default configuration works almost without customization. I decided to just renamestyle.cssto{Component}.module.cssin keeping with normal conventions for CSS modules.Responsive.Containerto TypeScript to test the problems with the currentbeta.2installation in our main app (something to do with auto-generated types with PropTypes)Pillcomponent to the updated format (minus thestory.jsfile):