Add basic Input component wrapper. #204
Merged
pixelbandito merged 2 commits intov1.xfrom Jun 1, 2020
Merged
Conversation
pixelbandito
requested review from
dkordik,
mdespuits,
nvmusoke and
sebastianvera
mdespuits
changed the title
mdespuits
suggested changes
Jun 1, 2020
Contributor
mdespuits
left a comment
mdespuits
left a comment
There was a problem hiding this comment.
One suggestion to change the version to bump the minor version and not both minor and patch. Otherwise looks great!
mdespuits
approved these changes
Jun 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll need to do this separately against master (v2 beta)
Fixes #202