Conversation
mdespuits
requested review from
dkordik,
nvmusoke,
pixelbandito and
sebastianvera
Contributor
Author
|
@pixelbandito Would it be reasonable to pass any additional props onto the underlying |
sebastianvera
approved these changes
Jun 11, 2020
Contributor
Author
|
@sebastianvera before i merge I’m going to pass extra props to the div in the case we want to pass any custom classes (for non-height adjustments) |
Contributor
Author
|
@sebastianvera Turns out it wasn't really necessary. Any styling of inner content should be done with the children themselves anyways and this can focus entirely on height. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #192.