Conversation
mdespuits
commented
Jun 15, 2020
| @@ -0,0 +1,4 @@ | |||
| import { createContext } from 'react'; | |||
|
|
|||
| const Context = createContext<string[] | undefined>(undefined); | |||
Contributor
Author
There was a problem hiding this comment.
I had to be explicit about defaultValue and set to undefined to preserve current behavior. See DefinitelyTyped/DefinitelyTyped#24509 (comment) for the explanation
| .add('Overview', () => ( | ||
| <div> | ||
| <Container readOnly style={{ resize: 'both' }}> | ||
| <Container readOnly className="resize"> |
pixelbandito
suggested changes
Jun 29, 2020
Contributor
pixelbandito
left a comment
pixelbandito
left a comment
There was a problem hiding this comment.
Couple of small change requests, couple of nitpicks.
Overall pretty sweet!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to do this a bit more piecemeal, but it seems like there are too many inter-dependencies for that to happen cleanly. Went ahead and converted everything related to Responsive-ness to TS.
Fixes #189