refactor: move sidetray to typescript#244
Merged
NicolasBiehler merged 9 commits intocision:masterfrom Aug 12, 2020
Merged
Conversation
sebastianvera
approved these changes
Jul 27, 2020
pixelbandito
suggested changes
Jul 27, 2020
NicolasBiehler
force-pushed
the
refactor/move-sidetray-to-typescript
branch
2 times, most recently
from
22f07b9 to
63614b5
Compare
mdespuits
suggested changes
Jul 29, 2020
NicolasBiehler
force-pushed
the
refactor/move-sidetray-to-typescript
branch
from
400a79b to
410f033
Compare
pixelbandito
approved these changes
Aug 10, 2020
mdespuits
reviewed
Aug 11, 2020
mdespuits
approved these changes
Aug 11, 2020
Contributor
mdespuits
left a comment
mdespuits
left a comment
There was a problem hiding this comment.
Only one small suggestion for improvement around the direction property type, but other than that...
🌹 🍔
…sion#252) * feat: InputTime dropdown menu has default max height of 10.5 rows fixes cision#249 * docs: Add InputTime stories for disabled and sans-validation cases * feat: InputTime has dropdownProps for customizing display of dropdown menu * refactor: InputTime Dropdown CSS refactor with clear variable names.
NicolasBiehler
force-pushed
the
refactor/move-sidetray-to-typescript
branch
from
fc82b9f to
cc34676
Compare
sebastianvera
approved these changes
Aug 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #197