Skip to content

test: Add InputTime/utils tests and prepare for timeZoneOffset prop#255

Merged
pixelbandito merged 3 commits intomasterfrom
input-time-utils-tests-and-time-zone-offset
Aug 17, 2020
Merged

test: Add InputTime/utils tests and prepare for timeZoneOffset prop#255
pixelbandito merged 3 commits intomasterfrom
input-time-utils-tests-and-time-zone-offset

Conversation

@pixelbandito
Copy link
Copy Markdown
Contributor

Tests cover behavior with and without timeZoneOffset

timeZoneOffset isn't used yet, but this prep work is intended to make its addition more seamless.

relates to #248

@pixelbandito pixelbandito force-pushed the input-time-utils-tests-and-time-zone-offset branch 2 times, most recently from 9135414 to 661580f Compare August 10, 2020 22:30
@pixelbandito pixelbandito changed the base branch from master to release-v2.4.0 August 10, 2020 22:36
Base automatically changed from release-v2.4.0 to master August 10, 2020 22:41
@pixelbandito pixelbandito force-pushed the input-time-utils-tests-and-time-zone-offset branch from 661580f to 7fc438b Compare August 10, 2020 22:41

const dropdownStep: number | undefined = useMemo(
() => (step && step >= 60 * 10 ? step : undefined),
() => (step && step >= SECONDS_PER_MINUTE * 10 ? step : undefined),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean code? 😛

@pixelbandito pixelbandito force-pushed the input-time-utils-tests-and-time-zone-offset branch from 7fc438b to 333f7cf Compare August 17, 2020 16:13
@pixelbandito pixelbandito merged commit 6d82a4a into master Aug 17, 2020
@pixelbandito pixelbandito deleted the input-time-utils-tests-and-time-zone-offset branch August 17, 2020 16:35
This was referenced Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants