Skip to content

Removed third-party theming systems from the project.#272

Merged
wendigolabs merged 5 commits intomasterfrom
remove-styled-components
Dec 15, 2020
Merged

Removed third-party theming systems from the project.#272
wendigolabs merged 5 commits intomasterfrom
remove-styled-components

Conversation

@wendigolabs
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@mdespuits mdespuits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍔🌹

@wendigolabs
Copy link
Copy Markdown
Contributor Author

Ahhh, I just noticed that Grid.test.js is still referencing theming, so I need to fix that. Kinda seems like that test should've failed? But then again there's a test farther down that seems to bless passing an unparsed gutter value through:

  describe('with garbage string in `gutter` prop', () => {
    it('renders', () => {
      mount(<Grid gutter="garbage-string" />);
    });
  });

?

@wendigolabs wendigolabs merged commit 5c141b4 into master Dec 15, 2020
@wendigolabs wendigolabs deleted the remove-styled-components branch December 15, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants