Chore: remove exclusive test and add prop type for test component#277
Merged
pixelbandito merged 2 commits intomasterfrom Oct 27, 2020
Merged
Conversation
pixelbandito
force-pushed
the
chore-remove-exclusive-test-and-add-prop-type-for-test-component
branch
from
27e17c4 to
000b203
Compare
pixelbandito
requested review from
dkordik,
nvmusoke and
wendigolabs
and removed request for
dkordik
wendigolabs
approved these changes
Oct 26, 2020
pixelbandito
force-pushed
the
chore-remove-exclusive-test-and-add-prop-type-for-test-component
branch
from
000b203 to
4159e97
Compare
pixelbandito
deleted the
chore-remove-exclusive-test-and-add-prop-type-for-test-component
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were running prettier during pre-commit hooks, but we weren't checking eslint.
I noticed because there was an exclusive test checked in, and we have a rule about that.
So, this change:
.onlyfrom a test