fix(hygen): fixes hygen + eslint bug#288
Merged
mikemfleming merged 2 commits intocision:masterfrom Dec 16, 2020
Merged
Conversation
pixelbandito
approved these changes
Dec 15, 2020
Contributor
pixelbandito
left a comment
pixelbandito
left a comment
There was a problem hiding this comment.
One super teeny thing
| /dist | ||
| /node_modules | ||
| /example | ||
| /src/stories No newline at end of file |
Contributor
There was a problem hiding this comment.
Small, but would you please add a newline at the end of this file?
And while you're at it, configure your editor to do it on save.
| "root": true, | ||
| "parser": "@typescript-eslint/parser", | ||
| "parserOptions": { | ||
| project: "tsconfig.json" |
dkordik
reviewed
Dec 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #283
Generating a new component and committing it would fail on the pre commit lint step. This updates makes the following updates:
tsstory file instead ofjsexampleandsrc/storiesfrom estlint