Typography cleanup#299
Merged
pixelbandito merged 2 commits intomasterfrom Feb 22, 2021
Merged
Conversation
Added "inherit" as an option for color, size, and weight, for use cases where the Typography component is partially overwriting styles in an already-styled block. Prefixed CSS module classnames with the "dimension", i.e. "inherit" -> "size--inherit". Removed "align" prop, since the component doesn't add anything to that use case (it just passed through the prop as a CSS `text-align` value). Updated some TS types in anticipation of added color, size, tag, and weight knobs to storybook.
...for color, size, tag, and weight props.
Contributor
Author
|
While verifying that That led down a short rabbit hole and some additional cleanup. |
Contributor
Author
|
fyi: Typography hasn't been released yet. The code is on master, waiting for a new release and version bump. |
bkonuwa
approved these changes
Feb 22, 2021
bkonuwa
reviewed
Feb 22, 2021
| color = 'primary', | ||
| className: passedClassName = '', | ||
| size = 'md', | ||
| size = 'medium', |
Contributor
There was a problem hiding this comment.
Curious... Why is this defaulted medium instead of md? The style class is defined as .size--md and the size type doesn't have a medium option.
Contributor
Author
There was a problem hiding this comment.
Oh, I didn't mean to do that! Thank you for catching it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.