feat: EVER-13448: Add input.Checkbox to RoverUI#316
Merged
pixelbandito merged 4 commits intomasterfrom May 20, 2021
Merged
Conversation
pixelbandito
commented
May 17, 2021
Contributor
Author
pixelbandito
left a comment
pixelbandito
left a comment
There was a problem hiding this comment.
Note to self
| width: 100%; | ||
| } | ||
|
|
||
| .input { |
Contributor
Author
There was a problem hiding this comment.
To make this a11y without extra code, I'm keeping the input present , invisible. The user is clicking the input, the SVG is just there for looks.
| border-color: var(--rvr-gray-40); | ||
| color: var(--rvr-gray-40); | ||
| border-color: var(--rvr-color-disabled); | ||
| box-shadow: none; |
Contributor
Author
There was a problem hiding this comment.
This was a UI bug! Focused "faux disabled" inputs still had a glow.
| --rvr-color-chart-yellow-lite: var(--rvr-yellow-alt-lite-1); | ||
| --rvr-color-font-dark: var(--rvr-gray-90); | ||
| --rvr-color-font: var(--rvr-gray-80); | ||
| --rvr-color-disabled: var(--rvr-gray-40); |
Contributor
Author
There was a problem hiding this comment.
Thought it deserved a semantic color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.