Media uses CSS modules instead of styled-system#83
Merged
Conversation
added 2 commits
August 5, 2019 11:50
This way, CSS classes from the main application can override any default styles since styled-components injects CSS later in the load process.
chelshaw
reviewed
Aug 5, 2019
|
|
||
| const Body = StyledBody; | ||
| Body.displayName = 'Media.Body'; | ||
| const FlexSpacer = withDefaultTheme(styled.div(flex, space)); |
Contributor
There was a problem hiding this comment.
Is this going to have similar issues to what we were seeing before?
Contributor
Author
There was a problem hiding this comment.
No, this only provides the component props that would allow us to set those values when we want. These don't add any styles by default
chelshaw
reviewed
Aug 5, 2019
chelshaw
suggested changes
Aug 5, 2019
Contributor
chelshaw
left a comment
chelshaw
left a comment
There was a problem hiding this comment.
the min-width thing is the only blocker
chelshaw
approved these changes
Aug 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, CSS classes from the main application can override any default styles since styled-components injects CSS later in the load process.