Skip to content

Add base Dropdown and Dropdown.Menu components#87

Merged
pixelbandito merged 2 commits intomasterfrom
feature/add-basic-dropdown
Aug 7, 2019
Merged

Add base Dropdown and Dropdown.Menu components#87
pixelbandito merged 2 commits intomasterfrom
feature/add-basic-dropdown

Conversation

@pixelbandito
Copy link
Copy Markdown
Contributor

No description provided.

@mdespuits
Copy link
Copy Markdown
Contributor

@pixelbandito One thing you should change in this PR is to change the release script. We actually don't want to add a yarn tag with the version. So you'll need to change this:

diff --git a/package.json b/package.json
index 807908d..47ad682 100644
--- a/package.json
+++ b/package.json
@@ -55,7 +55,7 @@
     "prepublish": "yarn test && yarn build",
     "predeploy": "cd example && yarn install && yarn run build",
     "postpublish": "git tag v$npm_package_version && git push --tags && echo \"Successfully released version $npm_pa
-    "release": "yarn publish . --tag $npm_package_version --no-git-tag-version",
+    "release": "yarn publish --no-git-tag-version",
     "deploy": "gh-pages -d example/build",
     "storybook": "start-storybook -p 9009",
     "build-storybook": "build-storybook"

@pixelbandito pixelbandito force-pushed the feature/add-basic-dropdown branch from 3f45bfe to 39703fb Compare August 6, 2019 20:22
@pixelbandito
Copy link
Copy Markdown
Contributor Author

@mdespuits I did that thing you asked for ^

@@ -0,0 +1,91 @@
import React from 'react';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@pixelbandito pixelbandito merged commit 96f3f70 into master Aug 7, 2019
@pixelbandito pixelbandito deleted the feature/add-basic-dropdown branch August 7, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants