Conversation
…eader to be available
carterpayne
approved these changes
Aug 19, 2019
| closeOnOutsideClick, | ||
| direction, | ||
| height, | ||
| marginTop, |
Contributor
There was a problem hiding this comment.
I see a couple of issues with this approach.
marginTopimplies that there should be configurability on other margins, and, since it's just a CSS style override, I'd rather see us spread astylesprop here (or something slightly more specific likewrapperStyles/backdropStyles).- Since we're setting a height to
100vhby default (for both backdrop and content, I think), the margin will technically be pushing content off the bottom of the page.
I think, ideally, we'd put both backdrop and side tray content in a single wrapper div, add a wrapperStyles there, that applies height: 100vh; width: 100vw; box-sizing: border-box; position: fixed; by default. We'd have side tray and backdrop use relative positioning and height: 100%; as their default.
Then, for this use case, set the wrapperStyle to paddingTop: 40px; and you get the child sizing for free.
pixelbandito
suggested changes
Aug 19, 2019
Contributor
pixelbandito
left a comment
There was a problem hiding this comment.
Left a single comment, but it would require some very small refactoring.
added 3 commits
August 20, 2019 08:20
chelshaw
approved these changes
Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: adds new arguments for the SideTray to allow for marginTop & have no backdrop/close on outside click. These new requirements for the sidetray will be used in a handfull of other areas throughout the application.
Risk: low, small isolated changes to SideTray