implement validation for identifiers screen#364
Merged
Conversation
|
✔️ Deploy Preview for cffinit ready! 🔨 Explore the source changes: 27b1b24 🔍 Inspect the deploy log: https://app.netlify.com/sites/cffinit/deploys/617a9ba26dd10800070a354c 😎 Browse the preview: https://deploy-preview-364--cffinit.netlify.app |
jspaaks
requested changes
Oct 28, 2021
Member
jspaaks
left a comment
jspaaks
left a comment
There was a problem hiding this comment.
nice additions, I saw the field level and object level validation working. However the screen level validation doesnt work just yet. Probably needs changes in Stepper:
This was referenced Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request details
Implemented validation for identifiers screen.
List of related issues or pull requests
Refs:
Describe the changes made in this pull request
Instructions to review the pull request