Skip to content

License dropdown improvements#367

Merged
abelsiqueira merged 3 commits intomainfrom
354-license-improvements
Oct 28, 2021
Merged

License dropdown improvements#367
abelsiqueira merged 3 commits intomainfrom
354-license-improvements

Conversation

@abelsiqueira
Copy link
Copy Markdown
Collaborator

Pull request details

List of related issues or pull requests

Refs: #354

Describe the changes made in this pull request

Auto-focus first item of dropdown during filtering, which allows immediate selection.
Also adds debounce=0 for quick filter and if the list is empty after filtering shows a "no results" message.

Instructions to review the pull request

image
image

cd $(mktemp -d --tmpdir cffinit-pr.XXXXXX)
git clone https://github.com/citation-file-format/cffinit .
git checkout <this branch>
npm clean-install
npm run dev
# go to localhost:8080, see if the app works correctly
npm run lint
npm run test:unit:ci

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 28, 2021

✔️ Deploy Preview for cffinit ready!

🔨 Explore the source changes: 54a6fa4

🔍 Inspect the deploy log: https://app.netlify.com/sites/cffinit/deploys/617a97b11b0ae1000761feba

😎 Browse the preview: https://deploy-preview-367--cffinit.netlify.app

Copy link
Copy Markdown
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks a lot @abelsiqueira 🍲

@abelsiqueira abelsiqueira merged commit b144708 into main Oct 28, 2021
@abelsiqueira abelsiqueira deleted the 354-license-improvements branch October 28, 2021 12:57
@abelsiqueira
Copy link
Copy Markdown
Collaborator Author

Thanks for the review 🍠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants