Finish button remains hidden until the user enters advanced mode

[abelsiqueira]

Pull request details

List of related issues or pull requests

Refs:

• Finish button should not be available for the first two screens/when there are errors #382

Describe the changes made in this pull request

Reuses showAdvanced to decide whether to hide the finish button or not.
This way:

• it is hidden before the user fixes the errors on Start and Authors - because he is soft-blocked from the advanced part;
• when he enters advanced, the finish button appears on all screens keeping consistency.

Instructions to review the pull request

cd $(mktemp -d --tmpdir cffinit-pr.XXXXXX)
git clone https://github.com/citation-file-format/cffinit .
git checkout <this branch>
npm clean-install
npm run dev
# go to localhost:8080, see if the app works correctly
npm run lint
npm run test:unit:ci

[sverhoeven]

Tested and the finish button is now hidden on start and authors screen. And the finish button is shown when in advanced mode. So PR works as expected.

Instead of a css class it would have nicer to use v-if="showAdvanced", but as the css class is already used for the other buttons in the component it makes sense using the same style.

[jspaaks]

Good job reusing stuff

[abelsiqueira]

Thanks for the review. (Emoji left blank)