Skip to content

Change layout of AuthorEdit and add SchemaGuideLinks#484

Merged
abelsiqueira merged 3 commits intomainfrom
457-authors-screen-icons
May 12, 2022
Merged

Change layout of AuthorEdit and add SchemaGuideLinks#484
abelsiqueira merged 3 commits intomainfrom
457-authors-screen-icons

Conversation

@abelsiqueira
Copy link
Copy Markdown
Collaborator

Pull request details

List of related issues or pull requests

Refs:

Describe the changes made in this pull request

Change the layout of AuthorEdit and add SchemaGuideLink.
image

I added the GuideLink inside the input because I couldn't make it look right otherwise.
I also increased the size and fixed the color of the info icon.

Instructions to review the pull request

cd $(mktemp -d --tmpdir cffinit-pr.XXXXXX)
git clone https://github.com/citation-file-format/cff-initializer-javascript .
git checkout <this branch>
npm clean-install
npm run dev
# go to localhost:8080, see if the app works correctly
npm run lint
npm run test:unit:ci

Copy link
Copy Markdown
Member

@jspaaks jspaaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "I added the GuideLink inside the input because I couldn't make it look right otherwise." that's alright, I had put the icons outside initially because I thought they woudl get in the way of the red circle that indicates a schema error. But as far as I can tell we don't generate any schema errors for name-suffix, family-names, and name-suffix, so no problem.
  • "I also increased the size and fixed the color of the info icon." Nice, helps to create a more unified look.
  • I did notice that the icon is currently included in the taborder order, not a huge problem but would be better if we can skip this somehow.
  • The text color for the q-labels should be a bit lighter to be the same as the questions. If I remember correctly, the color is a quasar css variable named --q-dark

@abelsiqueira abelsiqueira force-pushed the 457-authors-screen-icons branch from 9683770 to c3dba8e Compare May 11, 2022 14:49
@abelsiqueira
Copy link
Copy Markdown
Collaborator Author

Thanks for the review. I've updated the taborder and the color of the labels.

@abelsiqueira abelsiqueira requested a review from jspaaks May 11, 2022 14:51
Copy link
Copy Markdown
Member

@jspaaks jspaaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great one, thanks Abel! 🍰 🎉

@abelsiqueira
Copy link
Copy Markdown
Collaborator Author

Thanks for the review 🍕

@abelsiqueira abelsiqueira merged commit 82e2d7d into main May 12, 2022
@abelsiqueira abelsiqueira deleted the 457-authors-screen-icons branch May 12, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants