Change layout of AuthorEdit and add SchemaGuideLinks#484
Merged
abelsiqueira merged 3 commits intomainfrom May 12, 2022
Merged
Conversation
jspaaks
requested changes
May 11, 2022
Member
jspaaks
left a comment
There was a problem hiding this comment.
- "I added the GuideLink inside the input because I couldn't make it look right otherwise." that's alright, I had put the icons outside initially because I thought they woudl get in the way of the red circle that indicates a schema error. But as far as I can tell we don't generate any schema errors for
name-suffix,family-names, andname-suffix, so no problem. - "I also increased the size and fixed the color of the info icon." Nice, helps to create a more unified look.
- I did notice that the icon is currently included in the taborder order, not a huge problem but would be better if we can skip this somehow.
- The text color for the
q-labels should be a bit lighter to be the same as thequestions. If I remember correctly, the color is a quasar css variable named--q-dark
9683770 to
c3dba8e
Compare
Collaborator
Author
|
Thanks for the review. I've updated the taborder and the color of the labels. |
jspaaks
approved these changes
May 12, 2022
Member
jspaaks
left a comment
There was a problem hiding this comment.
Another great one, thanks Abel! 🍰 🎉
Collaborator
Author
|
Thanks for the review 🍕 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request details
List of related issues or pull requests
Refs:
Describe the changes made in this pull request
Change the layout of AuthorEdit and add SchemaGuideLink.

I added the GuideLink inside the input because I couldn't make it look right otherwise.
I also increased the size and fixed the color of the info icon.
Instructions to review the pull request