Skip to content

Open SchemaGuideLink links on a new window#487

Merged
abelsiqueira merged 1 commit intomainfrom
485-target-blank
May 12, 2022
Merged

Open SchemaGuideLink links on a new window#487
abelsiqueira merged 1 commit intomainfrom
485-target-blank

Conversation

@abelsiqueira
Copy link
Copy Markdown
Collaborator

Pull request details

List of related issues or pull requests

Refs:

Describe the changes made in this pull request

Open SchemaGuideLink links on a new window

Instructions to review the pull request

cd $(mktemp -d --tmpdir cffinit-pr.XXXXXX)
git clone https://github.com/citation-file-format/cff-initializer-javascript .
git checkout <this branch>
npm clean-install
npm run dev
# go to localhost:8080, see if the app works correctly
npm run lint
npm run test:unit:ci

And click a link

Copy link
Copy Markdown
Member

@jspaaks jspaaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works yay!

@abelsiqueira
Copy link
Copy Markdown
Collaborator Author

Thanks for the review

@abelsiqueira abelsiqueira merged commit c5e328e into main May 12, 2022
@abelsiqueira abelsiqueira deleted the 485-target-blank branch May 12, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants