Skip to content

updated placement of the SchemaGuideLink hint#494

Merged
jspaaks merged 1 commit intomainfrom
493-hint-overlaps-icon
May 17, 2022
Merged

updated placement of the SchemaGuideLink hint#494
jspaaks merged 1 commit intomainfrom
493-hint-overlaps-icon

Conversation

@jspaaks
Copy link
Copy Markdown
Member

@jspaaks jspaaks commented May 16, 2022

Pull request details

List of related issues or pull requests

Refs:

Describe the changes made in this pull request

This PR updates the classes on the q-icon / q-tooltip to have better placement of the hint / so it doesnt overlap the icon. I also changed the transition to an "appear"-like one, a change from the "roll in from above"

Screenshot of the result:

image

Instructions to review the pull request

cd $(mktemp -d --tmpdir cffinit-pr.XXXXXX)
git clone https://github.com/citation-file-format/cff-initializer-javascript .
git checkout 493-hint-overlaps-icon
npm clean-install
npm run dev
# go to localhost:8080, see if the app works correctly
npm run lint
npm run test:unit:ci

@jspaaks jspaaks changed the title updated placement of the SchemaGuideLink hint; refs #493 updated placement of the SchemaGuideLink hint May 16, 2022
@jspaaks jspaaks marked this pull request as ready for review May 16, 2022 12:36
@abelsiqueira abelsiqueira self-assigned this May 17, 2022
Copy link
Copy Markdown
Collaborator

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placement has been updated. Thanks for the PR. 🦅

@jspaaks
Copy link
Copy Markdown
Member Author

jspaaks commented May 17, 2022

Thank you sir for reviewing 🥚

@jspaaks jspaaks merged commit 4d9223b into main May 17, 2022
@jspaaks jspaaks deleted the 493-hint-overlaps-icon branch May 17, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants