Conversation
jspaaks
requested changes
May 17, 2022
Member
jspaaks
left a comment
jspaaks
left a comment
There was a problem hiding this comment.
Hi Faruk, thanks for this PR, I can see it working. I left some suggestions for minor changes throughout the diff. Additionally, I prefer to use the same font size and spacing for Identifiers as we have for Authors:
Co-authored-by: Jurriaan H. Spaaks <j.spaaks@esciencecenter.nl>
Co-authored-by: Jurriaan H. Spaaks <j.spaaks@esciencecenter.nl>
Co-authored-by: Jurriaan H. Spaaks <j.spaaks@esciencecenter.nl>
Co-authored-by: Jurriaan H. Spaaks <j.spaaks@esciencecenter.nl>
Co-authored-by: Jurriaan H. Spaaks <j.spaaks@esciencecenter.nl>
jspaaks
requested changes
May 17, 2022
Member
jspaaks
left a comment
jspaaks
left a comment
There was a problem hiding this comment.
- could you merge main branch into this
- It looks like the styling is not yet the same as we used in Abel's PR
- remove SchemaGuideLink in setup
otherwise good to go!
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR495/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request details
List of related issues or pull requests
Refs: #458
Describe the changes made in this pull request
See below for the screenshots.
Instructions to review the pull request