Update README.dev.md with information on the Preview workflow#502
Merged
abelsiqueira merged 2 commits intomainfrom May 18, 2022
Merged
Update README.dev.md with information on the Preview workflow#502abelsiqueira merged 2 commits intomainfrom
abelsiqueira merged 2 commits intomainfrom
Conversation
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR502/ |
jspaaks
approved these changes
May 18, 2022
Member
jspaaks
left a comment
jspaaks
left a comment
There was a problem hiding this comment.
Nice work, I left one question comment, but feel free to merge either way.
|
|
||
| - The branch `gh-preview` is served by Netlify. There is a folder `main` and several folders `PRXXX` in that branch. | ||
| - After a Pull Request or a push to `main` is created, the workflow runs. | ||
| - The workflow changes the `publicPath` configuration in <quasar.conf.js> to reflect the folder `main` or `PRXXX`. |
Member
There was a problem hiding this comment.
did you mean to linkify the quasar conf?
Collaborator
Author
There was a problem hiding this comment.
I did, thanks for catching it
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR502/ |
Collaborator
Author
|
Thanks for the review 📜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request details
List of related issues or pull requests
Refs: None
Describe the changes made in this pull request
Update README.dev.md with information on the Preview workflow
Instructions to review the pull request
Read online