Remove mentions of Vetur extension and add Volar to .vscode recommendations#554
Merged
abelsiqueira merged 2 commits intodevfrom Jun 9, 2022
Merged
Remove mentions of Vetur extension and add Volar to .vscode recommendations#554abelsiqueira merged 2 commits intodevfrom
abelsiqueira merged 2 commits intodevfrom
Conversation
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR554/ |
jspaaks
reviewed
Jun 8, 2022
jspaaks
approved these changes
Jun 8, 2022
Member
jspaaks
left a comment
jspaaks
left a comment
There was a problem hiding this comment.
Out of interest, do we know why any of the unwantedRecommendations are there? Do you think this is something we should document? For example, if one of those extensions clashes with something else we like to use.
Collaborator
Author
|
No idea. To be honest, I had not even noticed the recommendations. Maybe @fdiblen can shed a light? |
Co-authored-by: Jurriaan H. Spaaks <j.spaaks@esciencecenter.nl>
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR554/ |
Collaborator
Author
Collaborator
Author
|
Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request details
List of related issues or pull requests
Refs:
Describe the changes made in this pull request
Remove Vetur and add Volar.
Instructions to review the pull request
Review changes online.