Change p.question to h2.question and q-label to h3.subsquestion#558
Change p.question to h2.question and q-label to h3.subsquestion#558abelsiqueira merged 2 commits intodevfrom
Conversation
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR558/ |
| .question, .subquestion { | ||
| font-family: "Roboto Condensed", sans-serif; | ||
| color: #333; | ||
| font-size: 1.1rem; | ||
| font-weight: 400; | ||
| margin-top: 12px; | ||
| margin-bottom: 7px; | ||
| line-height: normal; | ||
| } | ||
| .subquestion { | ||
| font-size: 0.9rem; | ||
| margin: 0px; |
There was a problem hiding this comment.
I prefer to have two separate, complete class definitions with the same keys but different values.
Additionally, should we define a prose color variable in quasar.conf.js, it seems that we're using #333 for all the prose (we already have a variable dark: #333 but I'd like to not reuse that because we use that in elements that are semantically different)
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR558/ |
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR558/ |
jspaaks
left a comment
jspaaks
left a comment
There was a problem hiding this comment.
Looks great, thanks for making this
|
Thank you for the review. |
2 participants
Pull request details
List of related issues or pull requests
Refs:
Describe the changes made in this pull request
Changes
<p class="question">to<h2 class="question">and<q-label ...to<h3 class="subquestion">.Add style for
.subquestionto be almost the same as.question, but with 0 margin and smallerfont-size. Also changes theline-heightof.question, .subquestiontonormal, sinceh*had a different value.Instructions to review the pull request
grep questionfor missing<p>elements.