Skip to content

Conversation

@jspaaks
Copy link
Member

@jspaaks jspaaks commented Jun 14, 2022

Pull request details

List of related issues or pull requests

Refs:

  • N/A

Describe the changes made in this pull request

  • Fixed some broken links in AuthorCardEditing
  • Updated version strings to 2.0.3

Instructions to review the pull request

cd $(mktemp -d --tmpdir cffinit-pr.XXXXXX)
git clone https://github.com/citation-file-format/cff-initializer-javascript .
git checkout icon-links
npm clean-install
npm run dev
# go to localhost:8080, see if the app works correctly
npm run lint
npm run test:unit:ci

@github-actions
Copy link

Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR576/

@jspaaks jspaaks requested a review from fdiblen June 14, 2022 10:07
@jspaaks jspaaks marked this pull request as ready for review June 14, 2022 10:07
Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM. 🥼

@jspaaks jspaaks merged commit 6538604 into main Jun 14, 2022
@jspaaks jspaaks deleted the icon-links branch June 14, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants