Change the preview to a drawer when the screen is md or smaller #616
Conversation
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR616/ |
abelsiqueira
force-pushed
the
611-responsive
branch
from
b7cce60 to
9855de6
Compare
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR616/ |
|
For |
|
I would spawn an issue for responsiveness in small |
abelsiqueira
force-pushed
the
611-responsive
branch
from
9855de6 to
6a60ffd
Compare
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR616/ |
src/components/LayoutStepper.vue
Outdated
| <div id="app"> | ||
| <q-header id="header-inner"> | ||
| <Header /> | ||
| <Header v-on:togglePreview="togglePreview" /> |
There was a problem hiding this comment.
can you rename 'togglePreview' as 'onTogglePreview'
fdiblen
left a comment
fdiblen
left a comment
There was a problem hiding this comment.
Looks good @abelsiqueira . 🍖 Suggested a minor changes.
src/components/LayoutStepper.vue
Outdated
| elevated | ||
| overlay | ||
| side="right" | ||
| v-model="previewDrawer" |
There was a problem hiding this comment.
| v-model="previewDrawer" | |
| v-model="isPreviewDrawerEnabled" |
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR616/ |
|
Thanks for the review. 🦅 |
Pull request details
List of related issues or pull requests
Refs:
Describe the changes made in this pull request
When the screen is smaller than md size, use a overlay drawer for the cff preview instead of occupying space.
This PR consists of
Instructions to review the pull request
Verify in the preview that the screen is responsive, that the fields are readable in half screen, and that the author edit fields are readable in half-screen. Test the toggle with different sizes.