Skip to content

Change the preview to a drawer when the screen is md or smaller #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Change the preview to a drawer when the screen is md or smaller #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a60ffd
Change the preview to a drawer when the screen is md or smaller
abelsiqueira Aug 12, 2022
6ea18a9
Change Preview drawer variable names based on @fdiblen's review
abelsiqueira Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/components/Header.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,22 @@
target="_blank"
type="a"
/>
<q-btn
class="lt-lg"
icon="menu"
v-on:click="$emit('togglePreview')"
>
Preview
</q-btn>
</q-btn-group>
</template>

<script lang="ts">
import { defineComponent } from 'vue'

export default defineComponent({
name: 'Header'
name: 'Header',
emits: ['togglePreview']
})
</script>

Expand Down
40 changes: 35 additions & 5 deletions src/components/LayoutStepper.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,44 @@
<q-layout view="hHh lpR fFf">
<div id="app">
<q-header id="header-inner">
<Header />
<Header v-on:togglePreview="onTogglePreview" />
</q-header>

<q-drawer
id="preview-drawer"
elevated
overlay
side="right"
v-model="isPreviewDrawerEnabled"
width="600"
>
<div id="preview-button-close">
<q-btn
icon="close"
v-on:click="onTogglePreview"
>
Close preview
</q-btn>
</div>

<div id="preview-content">
<Preview />
</div>

<div id="preview-button-bar">
<DownloadButton v-if="isNotFinish" />
</div>
</q-drawer>

<q-page-container>
<q-page
id="middle"
class="row"
>
<router-view />
<div
id="preview"
class="col-12 col-md-4 col-sm-3"
id="preview-static"
class="col-12 col-lg-5 gt-md"
>
<div id="preview-content">
<Preview />
Expand All @@ -32,7 +59,7 @@
</template>

<script lang="ts">
import { computed, defineComponent } from 'vue'
import { computed, defineComponent, ref } from 'vue'
import DownloadButton from 'components/DownloadButton.vue'
import Footer from 'components/Footer.vue'
import Header from 'components/Header.vue'
Expand All @@ -48,11 +75,14 @@ export default defineComponent({
Footer
},
setup () {
const isPreviewDrawerEnabled = ref(false)
return {
isNotFinish: computed(() => {
const currentPath = useRoute().path
return currentPath !== '/finish-minimum' && currentPath !== '/finish-advanced'
})
}),
isPreviewDrawerEnabled,
onTogglePreview: () => { isPreviewDrawerEnabled.value = !isPreviewDrawerEnabled.value }
}
}
})
Expand Down
2 changes: 1 addition & 1 deletion src/components/ScreenAbstract.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<div
id="form"
class="col-12 col-lg-5 col-md-4 col-sm-3"
class="col-12 col-lg-5 col-sm-10"
>
<div id="form-title">
<h1 class="page-title">
Expand Down
2 changes: 1 addition & 1 deletion src/components/ScreenAuthors.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Stepper />
<div
id="form"
class="col-12 col-lg-5 col-md-4 col-sm-3"
class="col-12 col-lg-5 col-sm-10"
>
<div id="form-title">
<h1 class="page-title">
Expand Down
2 changes: 1 addition & 1 deletion src/components/ScreenFinishAdvanced.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Stepper />
<div
id="form"
class="col-12 col-md-6 col-sm-7"
class="col-12 col-lg-5 col-sm-10"
>
<div id="form-title">
<h1
Expand Down
2 changes: 1 addition & 1 deletion src/components/ScreenFinishMinimum.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Stepper />
<div
id="form"
class="col-12 col-md-6 col-sm-7"
class="col-12 col-lg-5 col-sm-10"
>
<div id="form-title">
<h1
Expand Down
2 changes: 1 addition & 1 deletion src/components/ScreenIdentifiers.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Stepper />
<div
id="form"
class="col-12 col-md-6 col-sm-7"
class="col-12 col-lg-5 col-sm-10"
>
<div id="form-title">
<h1 class="page-title">
Expand Down
2 changes: 1 addition & 1 deletion src/components/ScreenKeywords.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Stepper />
<div
id="form"
class="col-12 col-md-6 col-sm-7"
class="col-12 col-lg-5 col-sm-10"
>
<div id="form-title">
<h1 class="page-title">
Expand Down
2 changes: 1 addition & 1 deletion src/components/ScreenLicense.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Stepper />
<div
id="form"
class="col-12 col-md-6 col-sm-7"
class="col-12 col-lg-5 col-sm-10"
>
<div id="form-title">
<h1 class="page-title">
Expand Down
2 changes: 1 addition & 1 deletion src/components/ScreenRelatedResources.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Stepper />
<div
id="form"
class="col-12 col-md-6 col-sm-7"
class="col-12 col-lg-5 col-sm-10"
>
<div id="form-title">
<h1 class="page-title">
Expand Down
2 changes: 1 addition & 1 deletion src/components/ScreenStart.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<div
id="form"
class="col-12 col-md-6 col-sm-7"
class="col-12 col-lg-5 col-sm-10"
>
<div id="form-title">
<h1 class="page-title">
Expand Down
2 changes: 1 addition & 1 deletion src/components/ScreenVersionSpecific.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Stepper />
<div
id="form"
class="col-12 col-md-6 col-sm-7"
class="col-12 col-lg-5 col-sm-10"
>
<div id="form-title">
<h1 class="page-title">
Expand Down
10 changes: 9 additions & 1 deletion src/css/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ body {
max-height: 80px;
min-height: 80px;
}
#preview {
#preview-drawer, #preview-static {
background-color: var(--fgcolor, limegreen);
display: flex;
flex-direction: column;
Expand All @@ -76,6 +76,14 @@ body {
padding-top: 30px;
border-radius: 0px 7px 7px 0px;
}
#preview-button-close {
align-items: center;
display: flex;
flex-direction: row;
justify-content: center;
max-height: 80px;
min-height: 80px;
}
#preview-content {
background-color: var(--fgcolor, lightcoral);
display: flex;
Expand Down