move lastname i icons outside #686
Conversation
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR686/ |
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR686/ |
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR686/ |
abelsiqueira
left a comment
abelsiqueira
left a comment
There was a problem hiding this comment.
Thanks for the PR @fdiblen, I've found some minor changes.
src/components/AuthorCardEditing.vue
Outdated
| ] | ||
| }, | ||
| lastName: { | ||
| title: 'lastNames', |
There was a problem hiding this comment.
Our discussion on #646 led to this title being the name of the field.
This doesn't work here and it badly applies in other places like Identifiers.
We can merge this first and discuss how to proceed later, but we should create an issue from this comment.
There was a problem hiding this comment.
I updated the title to include all of the fields.
Co-authored-by: Abel Soares Siqueira <abel.s.siqueira@gmail.com>
Co-authored-by: Abel Soares Siqueira <abel.s.siqueira@gmail.com>
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR686/ |
1 similar comment
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR686/ |
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR686/ |
Co-authored-by: Abel Soares Siqueira <abel.s.siqueira@gmail.com>
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR686/ |
Co-authored-by: Abel Soares Siqueira <abel.s.siqueira@gmail.com>
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR686/ |
Pull request details
List of related issues or pull requests
Refs:
Describe the changes made in this pull request
Instructions to review the pull request