Add remove button to view cards in Author and Identifiers screens #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR691/ |
recap
approved these changes
Aug 29, 2022
Collaborator
Author
|
Thanks for the review. I will wait until after #686 to ensure that I don't cause a conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request details
List of related issues or pull requests
Refs:
Removebutton onAuthorCardViewingandIdentifierCardViewing#567Describe the changes made in this pull request
Generalizes the existing
removeAuthorandremoveIdentifierfunctions to receive an index.Uses the same function in the view and edit cards.
Emits a new
removePressedin the view cards.Instructions to review the pull request
Check the preview and test the deletion of authors and cards. Try deleting with an open card.