Skip to content

fix(extra-natives/five): make track junction ids permanent#3200

Closed
TheGamerzs wants to merge 1 commit intocitizenfx:masterfrom
TheGamerzs:natives-track-junction-fix
Closed

fix(extra-natives/five): make track junction ids permanent#3200
TheGamerzs wants to merge 1 commit intocitizenfx:masterfrom
TheGamerzs:natives-track-junction-fix

Conversation

@TheGamerzs
Copy link
Contributor

Goal of this PR

Make train junction ids permanent, not the relative index of the vector
Currently, the id will "change" if a junction is removed

How is this PR achieving the goal

Change junction vector to unmmapped_map
Creates a queue of unused ids

This PR applies to the following area(s)

FiveM

Successfully tested on

Game builds: 1607, 3407

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Feb 27, 2025
@radium-cfx radium-cfx self-assigned this May 19, 2025
@radium-cfx radium-cfx added manual-review PRs that need manual review and work before merging. and removed invalid Requires changes before it's considered valid and can be (re)triaged labels May 19, 2025
@prikolium-cfx
Copy link
Collaborator

Thank you for the contribution. Merged with some adjustments.

@TheGamerzs TheGamerzs deleted the natives-track-junction-fix branch May 21, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual-review PRs that need manual review and work before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants