fix(extra-natives/five): make track junction ids permanent#3200
Closed
TheGamerzs wants to merge 1 commit intocitizenfx:masterfrom
Closed
fix(extra-natives/five): make track junction ids permanent#3200TheGamerzs wants to merge 1 commit intocitizenfx:masterfrom
TheGamerzs wants to merge 1 commit intocitizenfx:masterfrom
Conversation
4 tasks
Collaborator
|
Thank you for the contribution. Merged with some adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Make train junction ids permanent, not the relative index of the vector
Currently, the id will "change" if a junction is removed
How is this PR achieving the goal
Change junction vector to unmmapped_map
Creates a queue of unused ids
This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: 1607, 3407
Platforms: Windows
Checklist