fix(citizen-server-impl): add the ability to restart categories for command: restart#3237
Closed
Kid-Sander wants to merge 4 commits intocitizenfx:masterfrom
Kid-Sander:master
Closed
fix(citizen-server-impl): add the ability to restart categories for command: restart#3237Kid-Sander wants to merge 4 commits intocitizenfx:masterfrom Kid-Sander:master
Kid-Sander wants to merge 4 commits intocitizenfx:masterfrom
Kid-Sander:master
Conversation
Corrected file: ServerResources.cpp. The changes concern the restart command, namely adding the ability to restart categories, as with the start/stop commands.
…nsole. A variation of the command was added: restart [resourceName] [isPrintStopedResource]. This allows you to remove the message “Can't restart a stopped resource.” from the display. This message was appearing when a category was restarted and it contained stopped resources. All other logic of the command has not changed.
|
You've got typo in |
Minor change to correct a typo in the word: “isPrintStoppedResource”
Author
Thank you for the observation. The typo has been corrected. |
Collaborator
|
Thank you for the contribution. We would like to not add additional complexity to resource manager system so I want to ask you to remove this additional argument and just do print something like |
Author
… one or more resources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Goal of this PR
Add the ability to restart categories for command: restart
...
How is this PR achieving the goal
Added ability to use: “restart [resourceCategory]” like start/stop. Also added a new variation of “restart [resourceCategory] [isPrintStoppedResource]” to avoid the situation where a category may contain a resource that is not running. All other behavioral logic remains the same.
...
This PR applies to the following area(s)
FiveM, RedM, Server
...
Successfully tested on
Platforms: Windows
Checklist
Fixes issues