Add documentation to ExecuteCommand native#3291
Merged
prikolium-cfx merged 1 commit intocitizenfx:masterfrom Apr 7, 2025
Merged
Add documentation to ExecuteCommand native#3291prikolium-cfx merged 1 commit intocitizenfx:masterfrom
prikolium-cfx merged 1 commit intocitizenfx:masterfrom
Conversation
Contributor
|
I checked the Register Command docs and they already cover that stuff. I think your PR might just be an oversight |
Contributor
Author
I disagree. Register Command does not mention ACLs for resources specifically. It only mentions players, and doesn't mention how to do it. It mentions that ExecuteCommand can be used to execute registered commands but again does not mention ACLs for resources. If anything, what would be better than this PR would be having resources mentioned in the add_ace example section |
prikolium-cfx
approved these changes
Apr 4, 2025
Collaborator
prikolium-cfx
left a comment
There was a problem hiding this comment.
Thanks for the contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
The goal of this PR is to help anyone else that experiences the same issue I did, with being unable to use ExecuteCommand in my resource, without first adding an acl for the resource, and attempting to google the issue only told me how to add ACLs for players.
How is this PR achieving the goal
This PR is achieving that goal by adding documentation to the ExecuteCommand native, to include a simple pointer towards how to add an acl for a resource.
This PR applies to the following area(s)
Natives
Successfully tested on
Game builds: N/A
Platforms: N/A
Checklist
Fixes issues
N/A