feat(net): add client-side ping, variance and packet loss natives#3911
Open
YgorLeal wants to merge 1 commit intocitizenfx:masterfrom
Open
feat(net): add client-side ping, variance and packet loss natives#3911YgorLeal wants to merge 1 commit intocitizenfx:masterfrom
YgorLeal wants to merge 1 commit intocitizenfx:masterfrom
Conversation
…ting Add three new client-side natives: GET_CLIENT_PING, GET_CLIENT_PING_VARIANCE, and GET_CLIENT_PACKET_LOSS. These values were already available internally via the ENet peer but not exposed to the scripting layer. Also adds GetPacketLoss() to the NetLibrary interface, following the same pattern as the existing GetPing() and GetVariance() methods. Fixes citizenfx#2233
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET_CLIENT_PING,GET_CLIENT_PING_VARIANCE, andGET_CLIENT_PACKET_LOSSGetPacketLoss()to theNetLibraryinterface, following the same pattern asGetPing()andGetVariance()Usage
Test plan
GetClientPing()returns a valid RTT in msGetClientPingVariance()returns RTT variance matchingnetgraph 1displayGetClientPacketLoss()returns packet loss percentage matchingcl_drawPacketLoss-1when not connected to any serverFixes #2233