[Bug] NetworkGetEntityOwner returns 65535 instead of -1 when server owns entity

[ihyajb]

Summary

Before in Legacy FiveM when an entity hasnt been assigned ownership yet NetworkGetEntityOwner always returned -1 now in enhanced the value is returned as 65535. Due to this existing checks in frameworks like qbox who spawn vehicles server-sided now break as they always wait until the owner of a vehicle is not -1 . Example from qbox below:

lib.waitFor(function()
    local owner = NetworkGetEntityOwner(veh)
    if ped then
        --- the owner should be transferred to the driver
        if owner == NetworkGetEntityOwner(ped) then return true end
    else
        if owner ~= -1 then return true end
    end
end, 'client never set as owner', 5000)

Issue type

Server

Repro rate

Always

Server build version

FXServer-early-access b96 win32

OS

No response

CPU

No response

GPU

No response

RAM

No response

Storage type

None

Connection type

None

ISP and bandwidth

No response

DxDiag

No response

Network graph

No response

Platform

None

OS version / distribution

No response

CPU

No response

RAM

No response

Using txAdmin?

None

Hosting provider

None

Machine type

None

/perf endpoint output

No response

DDoS protection

No response

ulimit -n value (Linux only)

No response

Docker Compose file (Docker only)

No response

Steps to Reproduce

In any server file:

RegisterCommand('ownership_bug1', function (source, args, raw)
    CreateThread(function (threadId)
        local tries = 0
        while true do
            tries += 1
            local coords = vec4(409.42, -1610.71, 28.29, 48.33)
            local veh = CreateVehicleServerSetter(`adder`, 'automobile', coords.x, coords.y, coords.z, coords.w)
            while not DoesEntityExist(veh) do Wait(0) end
            while GetVehicleNumberPlateText(veh) == '' do Wait(0) end
            local owner = NetworkGetEntityOwner(veh)
            print(string.format('Ownership of vehicle after 0 ticks is: %s', owner))
            DeleteEntity(veh)
            if tries >= 100 then
                print('Test Ended')
                break
            end
            Wait(100)
        end
    end)
end)

Expected Behavior

When the server hasnt yet given ownership to a client, NetworkGetEntityOwner should return -1

Actual Behavior

NetworkGetEntityOwner currently returns 65535

Evidence

Additional Context

No response

[wolfram-cfx]

Thanks, we are looking into this.

[ihyajb]

thanks, also btw 99% sure NetworkGetFirstEntityOwner has the same kinda issue. Was running into some weird issues where that was returning 65535

[wolfram-cfx]

The fix for this has been implemented, please try again.

[ihyajb]

Confirmed Fixed, thanks