[Bug] Using server KVP getters with no-sync setters can crash the server

[D4isDAVID]

Summary

Using GetResourceKvp... functions after running SetResourceKvp...NoSync before or immediately after running FlushResourceKvp crashes the server in Enhanced, when it used to work in Legacy. Sometimes with/without a crash message.

Issue type

Server

Repro rate

Often

Server build version

FXServer-early-access b92 win32

OS

No response

CPU

No response

GPU

No response

RAM

No response

Storage type

None

Connection type

None

ISP and bandwidth

No response

DxDiag

No response

Network graph

No response

Platform

Windows

OS version / distribution

Windows 11 Home 25H2

CPU

12th Gen Intel(R) Core(TM) i7-12700F

RAM

64 GB DDR5

Using txAdmin?

No

Hosting provider

Self-hosted

Machine type

Dedicated

/perf endpoint output

No response

DDoS protection

No response

ulimit -n value (Linux only)

No response

Docker Compose file (Docker only)

No response

Steps to Reproduce

Run:

SetResourceKvpNoSync('test', 'test')
GetResourceKvpString('test')
FlushResourceKvp()

Or

SetResourceKvpNoSync('test', 'test')
FlushResourceKvp()
GetResourceKvpString('test')

Expected Behavior

The setters and getters work properly before or immediately after flushing.

Actual Behavior

The server may crash when running the getter.

Evidence

Case 1

Example script:

CreateThread(function()
    print('setting')
    SetResourceKvpNoSync('test', 'test')

    print('getting')
    print(GetResourceKvpString('test'))

    print('flushing')
    FlushResourceKvp()
end)

Output:

cfx> ensure kvp_test
[21:33:18] [ info] [citizen-server-i] Starting resource kvp_test
[21:33:18] [ info] [citizen-server-i] Started resource kvp_test
[21:33:18] [ info] [        kvp_test] setting
[21:33:18] [ info] [        kvp_test] getting
[21:33:18] [ info] [        kvp_test] nil
[21:33:18] [ info] [        kvp_test] flushing
[21:33:18] [ warn] [           fivem] Failed to update key "res:kvp_test:test". Reason: database is locked
cfx> ensure kvp_test
[21:33:22] [ info] [citizen-server-i] Stopping resource kvp_test
[21:33:22] [ info] [citizen-server-i] Stopped resource kvp_test
[21:33:22] [ info] [citizen-server-i] Starting resource kvp_test
[21:33:22] [ info] [citizen-server-i] Starting resource kvp_test
[21:33:22] [ info] [citizen-server-i] Started resource kvp_test
[21:33:22] [ info] [        kvp_test] setting
[21:33:22] [ info] [        kvp_test] getting
<crash with no log>

Case 2

Example script:

CreateThread(function()
    print('setting')
    SetResourceKvpNoSync('test', 'test')

    print('flushing')
    FlushResourceKvp()

    print('getting')
    print(GetResourceKvpString('test'))
end)

Output:

cfx> ensure kvp_test
[21:33:56] [ info] [citizen-server-i] Starting resource kvp_test
[21:33:56] [ info] [citizen-server-i] Started resource kvp_test
[21:33:56] [ info] [        kvp_test] setting
[21:33:56] [ info] [        kvp_test] flushing
[21:33:56] [ info] [        kvp_test] getting
[21:33:56] [error] [           fivem] Job failed: no such table: �
[21:33:56] [ info] [        kvp_test] test
cfx> ensure kvp_test
[21:33:57] [ info] [citizen-server-i] Stopping resource kvp_test
[21:33:57] [ info] [citizen-server-i] Stopped resource kvp_test
[21:33:57] [ info] [citizen-server-i] Starting resource kvp_test
[21:33:57] [ info] [citizen-server-i] Starting resource kvp_test
[21:33:57] [ info] [citizen-server-i] Started resource kvp_test
[21:33:57] [ info] [        kvp_test] setting
[21:33:57] [ info] [        kvp_test] flushing
[21:33:57] [ info] [        kvp_test] getting
<crash with no log>

Additional Context

Adding a Wait(0) after using FlushResourceKvp() makes the getter work fine.

[D4isDAVID]

Seems fixed as of b93, however the functionality of using getters before flushing is still not aligned with Legacy. What's the plan for this?

Code:

local time = tostring(os.time())
print('setting', time)
SetResourceKvpNoSync('test', time)
print('getting', GetResourceKvpString('test'))
print('flushing')
FlushResourceKvp()

Legacy output (brand new db):

cfx> ensure kvp_test
[    c-scripting-core] Creating script environments for kvp_test
[           resources] Started resource kvp_test
[     script:kvp_test] setting  1784731573
[     script:kvp_test] getting  1784731573
[     script:kvp_test] flushing
cfx> ensure kvp_test
[           resources] Stopping resource kvp_test
[    c-scripting-core] Creating script environments for kvp_test
[           resources] Started resource kvp_test
[     script:kvp_test] setting  1784731575
[     script:kvp_test] getting  1784731575
[     script:kvp_test] flushing
cfx> ensure kvp_test
[           resources] Stopping resource kvp_test
[    c-scripting-core] Creating script environments for kvp_test
[           resources] Started resource kvp_test
[     script:kvp_test] setting  1784731576
[     script:kvp_test] getting  1784731576
[     script:kvp_test] flushing

Enhanced output (brand new db):

cfx> ensure kvp_test
[17:47:03] [ info] [citizen-server-i] Starting resource kvp_test
[17:47:03] [ info] [citizen-server-i] Started resource kvp_test
[17:47:03] [ info] [        kvp_test] setting   1784731623
[17:47:03] [ info] [        kvp_test] getting   nil
[17:47:03] [ info] [        kvp_test] flushing
cfx> ensure kvp_test
[17:47:04] [ info] [citizen-server-i] Stopping resource kvp_test
[17:47:04] [ info] [citizen-server-i] Stopped resource kvp_test
[17:47:04] [ info] [citizen-server-i] Starting resource kvp_test
[17:47:04] [ info] [citizen-server-i] Starting resource kvp_test
[17:47:04] [ info] [citizen-server-i] Started resource kvp_test
[17:47:04] [ info] [        kvp_test] setting   1784731624
[17:47:04] [ info] [        kvp_test] getting   1784731623
[17:47:04] [ info] [        kvp_test] flushing
cfx> ensure kvp_test
[17:47:09] [ info] [citizen-server-i] Stopping resource kvp_test
[17:47:09] [ info] [citizen-server-i] Stopped resource kvp_test
[17:47:09] [ info] [citizen-server-i] Starting resource kvp_test
[17:47:09] [ info] [citizen-server-i] Starting resource kvp_test
[17:47:09] [ info] [citizen-server-i] Started resource kvp_test
[17:47:09] [ info] [        kvp_test] setting   1784731629
[17:47:09] [ info] [        kvp_test] getting   1784731624
[17:47:09] [ info] [        kvp_test] flushing

[spacevx]

You should probably close this one and open a new one?
or edit the title of this one