Skip to content

Drops PG15 support#8372

Merged
naisila merged 11 commits intomainfrom
naisila/drop-pg15
Dec 15, 2025
Merged

Drops PG15 support#8372
naisila merged 11 commits intomainfrom
naisila/drop-pg15

Conversation

@naisila
Copy link
Contributor

@naisila naisila commented Dec 7, 2025

DESCRIPTION: Drops PG15 support

Steps involved:

  • Remove pg15 from configure

  • Remove PG_VERSION_15 lines

  • Delete ruleutils_15.c

  • Remove PG_VERSION_NUM >= 16 and PG_VERSION_NUM < 16

  • Remove pg_version_compat.h '>= PGVERSION_16' entries

  • Clean up server_version_ge_16 from tests

  • Remove pg15 CI tests

  • Remove normalize rules specific to PG15 diffs

  • Rename pg_get_object_address_13_14_15.c to pg_get_object_address_16_17_18.c

  • Remove PG15 obsolete comments

  • Remove PG15 from pseudoconstant qual error

Note to reviewer: You can review commit by commit, the commit message should be explanatory enough. You can ignore the flakyness failures.

Fixes #8351

Sister PR citusdata/the-process#178

@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.73%. Comparing base (0e110ee) to head (4a5be6f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8372      +/-   ##
==========================================
- Coverage   88.94%   88.73%   -0.21%     
==========================================
  Files         287      287              
  Lines       63153    63019     -134     
  Branches     7939     7891      -48     
==========================================
- Hits        56169    55922     -247     
- Misses       4671     4781     +110     
- Partials     2313     2316       +3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

naisila added a commit to citusdata/the-process that referenced this pull request Dec 12, 2025
Removes PG15 images since we are dropping PG15 support in Citus.

Sister PR citusdata/citus#8372
@naisila naisila force-pushed the naisila/drop-pg15 branch 3 times, most recently from 644b7ed to b79d259 Compare December 12, 2025 10:14
@naisila naisila marked this pull request as ready for review December 12, 2025 10:51
Copy link
Collaborator

@eaydingol eaydingol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great.

In a few places, some comments seem to be obsolete after pg15 support is dropped, like deparse_table_statements 181-183, adaptive executor look for PG15+, recursive planning 531-533 (no need for pg15 there), multi_logical_replication function comment.
Please review these and update them as you see fit.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a historical reason to name the file _13_14_15? , If this is related to the supported pg versions, can we update the file name and maybe the comment in it?

Copy link
Contributor Author

@naisila naisila Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I will rename the file. The header itself says

 * We need to make sure that function works with future PG versions. Update
 * the function name according to supported PG versions as well.
 *

@naisila naisila merged commit 62a9190 into main Dec 15, 2025
85 of 117 checks passed
@naisila naisila deleted the naisila/drop-pg15 branch December 15, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop PG15 support

2 participants