Conversation
b5207c9 to
3b84985
Compare
3b84985 to
1c1be2d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8372 +/- ##
==========================================
- Coverage 88.94% 88.73% -0.21%
==========================================
Files 287 287
Lines 63153 63019 -134
Branches 7939 7891 -48
==========================================
- Hits 56169 55922 -247
- Misses 4671 4781 +110
- Partials 2313 2316 +3 🚀 New features to boost your workflow:
|
1c1be2d to
973f3b9
Compare
Removes PG15 images since we are dropping PG15 support in Citus. Sister PR citusdata/citus#8372
644b7ed to
b79d259
Compare
eaydingol
left a comment
There was a problem hiding this comment.
Thanks, looks great.
In a few places, some comments seem to be obsolete after pg15 support is dropped, like deparse_table_statements 181-183, adaptive executor look for PG15+, recursive planning 531-533 (no need for pg15 there), multi_logical_replication function comment.
Please review these and update them as you see fit.
There was a problem hiding this comment.
Is there a historical reason to name the file _13_14_15? , If this is related to the supported pg versions, can we update the file name and maybe the comment in it?
There was a problem hiding this comment.
Good catch, I will rename the file. The header itself says
* We need to make sure that function works with future PG versions. Update
* the function name according to supported PG versions as well.
*baed75b to
4a5be6f
Compare
DESCRIPTION: Drops PG15 support
Steps involved:
Remove pg15 from configure
Remove PG_VERSION_15 lines
Delete ruleutils_15.c
Remove PG_VERSION_NUM >= 16 and PG_VERSION_NUM < 16
Remove pg_version_compat.h '>= PGVERSION_16' entries
Clean up server_version_ge_16 from tests
Remove pg15 CI tests
Remove normalize rules specific to PG15 diffs
Rename
pg_get_object_address_13_14_15.ctopg_get_object_address_16_17_18.cRemove PG15 obsolete comments
Remove PG15 from pseudoconstant qual error
Note to reviewer: You can review commit by commit, the commit message should be explanatory enough. You can ignore the flakyness failures.
Fixes #8351
Sister PR citusdata/the-process#178