Support extended stats creation on expressions#8501

Merged

colm-mchugh merged 4 commits intocitusdata:mainfrom

visridha:visridha/add_stats_creation_on_expressions

Mar 10, 2026

Contributor

visridha commented Mar 9, 2026

DESCRIPTION: Support extended stats creation on expressions
CREATE STATISTICS today gets pushed to the shards only if the statistics is on a column expression. However, PG14 added support for expressions (opExpr, FuncExprs) etc. This change adds support for it under a GUC.
This reuses the same logic as CHECK constraints to parse, transform, and deparse the exprs and add it to the statistics call.

visridha added 3 commits

March 9, 2026 19:29


          Support stats creation on expressions

ae832b5


          fix indent

2e7b28b


          more

2bc09f7

onurctirtir approved these changes

View reviewed changes

src/backend/distributed/shared_library_init.c Outdated Show resolved Hide resolved

colm-mchugh reviewed

View reviewed changes

src/test/regress/sql/propagate_statistics.sql Outdated Show resolved Hide resolved

colm-mchugh reviewed

View reviewed changes

src/test/regress/sql/propagate_statistics.sql Show resolved Hide resolved

colm-mchugh reviewed

View reviewed changes

src/backend/distributed/shared_library_init.c Outdated Show resolved Hide resolved

colm-mchugh reviewed

View reviewed changes

src/backend/distributed/deparser/deparse_statistics_stmts.c Outdated Show resolved Hide resolved

colm-mchugh reviewed

View reviewed changes

src/backend/distributed/deparser/deparse_statistics_stmts.c Outdated Show resolved Hide resolved

colm-mchugh approved these changes

View reviewed changes

Contributor

colm-mchugh left a comment

I left a couple of code questions and test suggestions, nice addition overall, thx.


          PR feedback

0c82ac3

colm-mchugh reviewed

View reviewed changes

src/backend/distributed/deparser/deparse_statistics_stmts.c

+              				 * cannot be found.
+              				 */
+              				Relation relation = table_open(relOid, AccessShareLock);
+              				ParseState *pstate = make_parsestate(NULL);

Contributor

colm-mchugh Mar 10, 2026

A take-it-or-leave-it suggestion: acquire the table lock and create the ParseState once at the top of the function so they're done once regardless of number of expressions in the CREATE STATISTICS. Not essential as we're in DDL, and it may not be worth complicating the code for, but just putting forward for consideration.

colm-mchugh merged commit ad2140d into citusdata:main

156 checks passed

onurctirtir mentioned this pull request

Remove citus.enable_unsafe_statistics_expressions GUC and always enable the feature #8512

Merged

onurctirtir added a commit that referenced this pull request


          Remove citus.enable_unsafe_statistics_expressions GUC and always enab…

84ddcd9

…le the feature (#8512)

Removing the GUC introduced at
#8501 as it's not needed at all.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: onurctirtir <16804727+onurctirtir@users.noreply.github.com>

onurctirtir pushed a commit that referenced this pull request


          Support extended stats creation on expressions (#8501)

23b1446

DESCRIPTION: Support extended stats creation on expressions

CREATE STATISTICS today gets pushed to the shards only if the statistics
is on a column expression. However, PG14 added support for expressions
(opExpr, FuncExprs) etc. This change adds support for it under a GUC.
This reuses the same logic as CHECK constraints to parse, transform, and
deparse the exprs and add it to the statistics call.

(cherry picked from commit ad2140d)

Conflicts:
	src/backend/distributed/deparser/deparse_statistics_stmts.c

onurctirtir added a commit that referenced this pull request


          Remove citus.enable_unsafe_statistics_expressions GUC and always enab…

ea7e5fc

…le the feature (#8512)

Removing the GUC introduced at
#8501 as it's not needed at all.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: onurctirtir <16804727+onurctirtir@users.noreply.github.com>
(cherry picked from commit 84ddcd9)

onurctirtir pushed a commit that referenced this pull request


          Support extended stats creation on expressions (#8501)

c5aaf2b

DESCRIPTION: Support extended stats creation on expressions

CREATE STATISTICS today gets pushed to the shards only if the statistics
is on a column expression. However, PG14 added support for expressions
(opExpr, FuncExprs) etc. This change adds support for it under a GUC.
This reuses the same logic as CHECK constraints to parse, transform, and
deparse the exprs and add it to the statistics call.

(cherry picked from commit ad2140d)

Conflicts:
	src/backend/distributed/deparser/deparse_statistics_stmts.c

onurctirtir added a commit that referenced this pull request


          Remove citus.enable_unsafe_statistics_expressions GUC and always enab…

cdb6a1b

…le the feature (#8512)

Removing the GUC introduced at
#8501 as it's not needed at all.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: onurctirtir <16804727+onurctirtir@users.noreply.github.com>
(cherry picked from commit 84ddcd9)

onurctirtir pushed a commit that referenced this pull request


          Support extended stats creation on expressions (#8501)

DESCRIPTION: Support extended stats creation on expressions

CREATE STATISTICS today gets pushed to the shards only if the statistics
is on a column expression. However, PG14 added support for expressions
(opExpr, FuncExprs) etc. This change adds support for it under a GUC.
This reuses the same logic as CHECK constraints to parse, transform, and
deparse the exprs and add it to the statistics call.

(cherry picked from commit ad2140d)

Conflicts:
	src/backend/distributed/deparser/deparse_statistics_stmts.c

onurctirtir added a commit that referenced this pull request


          Remove citus.enable_unsafe_statistics_expressions GUC and always enab…

4b6ee1c

…le the feature (#8512)

Removing the GUC introduced at
#8501 as it's not needed at all.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: onurctirtir <16804727+onurctirtir@users.noreply.github.com>
(cherry picked from commit 84ddcd9)

onurctirtir pushed a commit that referenced this pull request


          Support extended stats creation on expressions (#8501)

b036f9c

DESCRIPTION: Support extended stats creation on expressions

CREATE STATISTICS today gets pushed to the shards only if the statistics
is on a column expression. However, PG14 added support for expressions
(opExpr, FuncExprs) etc. This change adds support for it under a GUC.
This reuses the same logic as CHECK constraints to parse, transform, and
deparse the exprs and add it to the statistics call.

(cherry picked from commit ad2140d)

Conflicts:
	src/backend/distributed/deparser/deparse_statistics_stmts.c

onurctirtir added a commit that referenced this pull request


          Remove citus.enable_unsafe_statistics_expressions GUC and always enab…

8642e91

…le the feature (#8512)

Removing the GUC introduced at
#8501 as it's not needed at all.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: onurctirtir <16804727+onurctirtir@users.noreply.github.com>
(cherry picked from commit 84ddcd9)

onurctirtir pushed a commit that referenced this pull request


          Support extended stats creation on expressions (#8501)

51c63b5

DESCRIPTION: Support extended stats creation on expressions

CREATE STATISTICS today gets pushed to the shards only if the statistics
is on a column expression. However, PG14 added support for expressions
(opExpr, FuncExprs) etc. This change adds support for it under a GUC.
This reuses the same logic as CHECK constraints to parse, transform, and
deparse the exprs and add it to the statistics call.

(cherry picked from commit ad2140d)

Conflicts:
	src/backend/distributed/deparser/deparse_statistics_stmts.c

onurctirtir added a commit that referenced this pull request


          Remove citus.enable_unsafe_statistics_expressions GUC and always enab…

a985ca3

…le the feature (#8512)

Removing the GUC introduced at
#8501 as it's not needed at all.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: onurctirtir <16804727+onurctirtir@users.noreply.github.com>
(cherry picked from commit 84ddcd9)

onurctirtir pushed a commit that referenced this pull request


          Support extended stats creation on expressions (#8501)

3379f4f

DESCRIPTION: Support extended stats creation on expressions

CREATE STATISTICS today gets pushed to the shards only if the statistics
is on a column expression. However, PG14 added support for expressions
(opExpr, FuncExprs) etc. This change adds support for it under a GUC.
This reuses the same logic as CHECK constraints to parse, transform, and
deparse the exprs and add it to the statistics call.

(cherry picked from commit ad2140d)

Conflicts:
	src/backend/distributed/deparser/deparse_statistics_stmts.c

onurctirtir added a commit that referenced this pull request


          Remove citus.enable_unsafe_statistics_expressions GUC and always enab…

b52f8bd

…le the feature (#8512)

Removing the GUC introduced at
#8501 as it's not needed at all.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: onurctirtir <16804727+onurctirtir@users.noreply.github.com>

onurctirtir pushed a commit that referenced this pull request


          Support extended stats creation on expressions (#8501)

c13ed38

DESCRIPTION: Support extended stats creation on expressions

CREATE STATISTICS today gets pushed to the shards only if the statistics
is on a column expression. However, PG14 added support for expressions
(opExpr, FuncExprs) etc. This change adds support for it under a GUC.
This reuses the same logic as CHECK constraints to parse, transform, and
deparse the exprs and add it to the statistics call.

(cherry picked from commit ad2140d)

Conflicts:
	src/backend/distributed/deparser/deparse_statistics_stmts.c
(cherry picked from commit 23b1446)

onurctirtir added a commit that referenced this pull request


          Remove citus.enable_unsafe_statistics_expressions GUC and always enab…

d7c86e1

…le the feature (#8512)

Removing the GUC introduced at
#8501 as it's not needed at all.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: onurctirtir <16804727+onurctirtir@users.noreply.github.com>
(cherry picked from commit 84ddcd9)

onurctirtir pushed a commit that referenced this pull request


          Support extended stats creation on expressions (#8501)

f340c88

DESCRIPTION: Support extended stats creation on expressions

CREATE STATISTICS today gets pushed to the shards only if the statistics
is on a column expression. However, PG14 added support for expressions
(opExpr, FuncExprs) etc. This change adds support for it under a GUC.
This reuses the same logic as CHECK constraints to parse, transform, and
deparse the exprs and add it to the statistics call.

(cherry picked from commit ad2140d)

Conflicts:
	src/backend/distributed/deparser/deparse_statistics_stmts.c

onurctirtir added a commit that referenced this pull request


          Remove citus.enable_unsafe_statistics_expressions GUC and always enab…

e53a2f5

…le the feature (#8512)

Removing the GUC introduced at
#8501 as it's not needed at all.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: onurctirtir <16804727+onurctirtir@users.noreply.github.com>
(cherry picked from commit 84ddcd9)

onurctirtir pushed a commit that referenced this pull request


          Support extended stats creation on expressions (#8501)

cafc58c

DESCRIPTION: Support extended stats creation on expressions

CREATE STATISTICS today gets pushed to the shards only if the statistics
is on a column expression. However, PG14 added support for expressions
(opExpr, FuncExprs) etc. This change adds support for it under a GUC.
This reuses the same logic as CHECK constraints to parse, transform, and
deparse the exprs and add it to the statistics call.

(cherry picked from commit ad2140d)

Conflicts:
	src/backend/distributed/deparser/deparse_statistics_stmts.c

onurctirtir added a commit that referenced this pull request


          Remove citus.enable_unsafe_statistics_expressions GUC and always enab…

6cb9a73

…le the feature (#8512)

Removing the GUC introduced at
#8501 as it's not needed at all.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: onurctirtir <16804727+onurctirtir@users.noreply.github.com>
(cherry picked from commit 84ddcd9)

onurctirtir pushed a commit that referenced this pull request


          Support extended stats creation on expressions (#8501)

3890b58

DESCRIPTION: Support extended stats creation on expressions

CREATE STATISTICS today gets pushed to the shards only if the statistics
is on a column expression. However, PG14 added support for expressions
(opExpr, FuncExprs) etc. This change adds support for it under a GUC.
This reuses the same logic as CHECK constraints to parse, transform, and
deparse the exprs and add it to the statistics call.

(cherry picked from commit ad2140d)

Conflicts:
	src/backend/distributed/deparser/deparse_statistics_stmts.c

onurctirtir added a commit that referenced this pull request


          Remove citus.enable_unsafe_statistics_expressions GUC and always enab…

c3a7e9f

…le the feature (#8512)

Removing the GUC introduced at
#8501 as it's not needed at all.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: onurctirtir <16804727+onurctirtir@users.noreply.github.com>
(cherry picked from commit 84ddcd9)

onurctirtir pushed a commit that referenced this pull request


          Support extended stats creation on expressions (#8501)

685b016

DESCRIPTION: Support extended stats creation on expressions

CREATE STATISTICS today gets pushed to the shards only if the statistics
is on a column expression. However, PG14 added support for expressions
(opExpr, FuncExprs) etc. This change adds support for it under a GUC.
This reuses the same logic as CHECK constraints to parse, transform, and
deparse the exprs and add it to the statistics call.

(cherry picked from commit ad2140d)

Conflicts:
	src/backend/distributed/deparser/deparse_statistics_stmts.c

onurctirtir added a commit that referenced this pull request


          Remove citus.enable_unsafe_statistics_expressions GUC and always enab…

fe25f68

…le the feature (#8512)

Removing the GUC introduced at
#8501 as it's not needed at all.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: onurctirtir <16804727+onurctirtir@users.noreply.github.com>
(cherry picked from commit 84ddcd9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet