Bump docker to 9.5.0#201
Merged
onurctirtir merged 3 commits intomasterfrom Nov 12, 2020
Merged
Conversation
onurctirtir
force-pushed
the
release-9.5.0-1605172832
branch
from
7052526 to
c122c3e
Compare
onurctirtir
force-pushed
the
release-9.5.0-1605172832
branch
from
c122c3e to
6d468a5
Compare
onurctirtir
commented
Nov 12, 2020
Comment on lines
+20
to
23
| && apt-get install -y postgresql-$PG_MAJOR-citus-9.5.=$CITUS_VERSION \ | ||
| postgresql-$PG_MAJOR-hll=2.14.citus-1 \ | ||
| postgresql-$PG_MAJOR-topn=2.3.0 \ | ||
| && apt-get purge -y --auto-remove curl \ |
Member
Author
There was a problem hiding this comment.
this breaks docker builds as we don't have pg13 packages for hll & topn yet
Member
There was a problem hiding this comment.
Let's just remove these lines for now, until we have PG13 packages for hll and topn
As we didn't release pg13 for them yet, we cannot include them in our docker images for now. This commit will be reverted when we release pg13 packages for them.
hanefi
requested changes
Nov 12, 2020
| @@ -1,3 +1,9 @@ | |||
| ### citus-docker v9.5.0.docker (November 12, 2020) ### | |||
Member
There was a problem hiding this comment.
Maybe we should add some entries for missing topn and hll packages in this image. Users could run CREATE EXTENSION hll previously, and now they cannot do this. I think this should be documented somewhere
Member
Author
|
Sorry, couldn't wait that slow ci :/ But changelog edit shouldn't break |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.