-
Notifications
You must be signed in to change notification settings - Fork 101
Adds hyperscale image for pg14 #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Adds citus database * Adds grants for extensions * Adds extension functions * Reorganizes sql script order
8b70f33 to
c2f9948
Compare
* Parameterizes citus user password * Some format changes
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
marcocitus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
I wonder whether there are any settings we should replicate, but from a quick look I did not see anything super important.
|
[11/18/2021 1:42 PM] Marco Slot [11/18/2021 1:42 PM] Marco Slot [11/18/2021 1:42 PM] Marco Slot [11/18/2021 1:42 PM] Marco Slot [11/18/2021 1:42 PM] Marco Slot [11/18/2021 1:43 PM] Marco Slot |
[11/18/2021 1:42 PM] Marco Slot [11/18/2021 1:42 PM] Marco Slot [11/18/2021 1:42 PM] Marco Slot [11/18/2021 1:42 PM] Marco Slot [11/18/2021 1:42 PM] Marco Slot [11/18/2021 1:43 PM] Marco Slot I performed some configurations that prevent postgres user to connect into the image First I added connection policies to prevent postgres user to connect locally. Lines 94 to 96 in 1fe2a6c
Then I added random possword to prevent connecting using host
|
marcocitus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I seem to be getting an error now:
$ docker run --name test1 -p 5432:5432 -e CITUS_PASSWORD=Citus123 hyperscale_image
docker: Error response from daemon: OCI runtime create failed: container_linux.go:380: starting container process caused: exec: "docker-entrypoint.sh": executable file not found in $PATH: unknown.
|
Probably a file permissions problem. Adding |
I was trying to replicate it in my local. You found the problem thanks. I added execute permission into the file in git repository. This will fix it. No need to add additional command on Dockerfile |
* Fixes pg_cron connectivity problem * Removes stale comments * Adds comment for postgres random password set
a724413 to
dcd663e
Compare
are not template-generated
hanefi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have a section on the README.md with some details on how to use the docker images we create for hyperscale.
This may be done on a separate PR, and possibly we can write some documentation for the docker images with pg12, pg13, alpine etc.
Created the image for pg 14. I will need to create for each pg version.
I haven't added a user with the privileges you sent. I will add it after you first pre-review
you can create a new docker image in the docker repo with the command below
PG14
docker build -t hyperscale_image_14 -f hyperscale/pg-14/Dockerfile .
PG13
docker build -t hyperscale_image_13 -f hyperscale/pg-13/Dockerfile .
PG12
docker build -t hyperscale_image_12 -f hyperscale/pg-12/Dockerfile .
and run with the following command (replacing with the pg version you give above)
docker run --name test1 -p 5432:5432 -e CITUS_PASSWORD="Citus123" hyperscale_image_
I compared the plugins between the docker image I created and th list you've sent and the comparison excel is below
Hyperscale Image Extensions.xlsx