Update test images#40
Merged
SaitTalhaNisanci merged 1 commit intomasterfrom Aug 26, 2020
Merged
Conversation
As we are separating the builds for each pg major, we needed to add some additional packages to some of the images to be able to pass configure and run tests.
thanodnl
approved these changes
Aug 26, 2020
Comment on lines
+61
to
+66
| # we need autoconf and build-essential for running the tests | ||
| # we need other libraries for configure to pass, even though we could use | ||
| # --without-libcurl while configuring, we prefer this for now. | ||
| apt-get install -y autoconf build-essential libcurl4-openssl-dev \ | ||
| libicu-dev libreadline-dev libselinux1-dev libxslt-dev libssl-dev | ||
|
|
Contributor
There was a problem hiding this comment.
Was scared this could add a lot of data. Did an experiment by commenting out this line and check the layer size difference in docker image history. This showed these packages add only 2mb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we are separating the builds for each pg major, we needed to add some
additional packages to some of the images to be able to pass configure
and run tests.