Adds support for onebranch changes by gurkanindibay · Pull Request #233 · citusdata/tools

gurkanindibay · 2022-07-25T20:44:58Z

Onebranch pipelines have different structure from both Github Actions and Azure Devops since pipeline logic executes in docker images. As you may know main execution environment for both Github Actions and Azure Devops are ubuntu focal virtual machine, not container. Therefore we can execute docker run inside our python scripts
Since OneBranch pipelines does not have VM execution feature and we can only use docker images as the main execution environment and since we can not run docker run inside another docker, we need to use our docker images one by one as the main execution environment in OneBranch pipelines.
In that case we need to execute the logic inside citus_package script, which executes docker run in it, inside OneBranch pipeline scripts explicitly. Therefore we needed two new methods for validation and getting postgres versions
Additionally, current packaging images just execute a script then exists. However, this is not suitable for OneBranch container lifecyle since image is initialized and kept open until the end of the pipeline. Therefore I added a new parameter CONTAINER_BUILD_RUN_ENABLED to be able to keep the container open in absence of this parameter, since One Branch container initialization phase

We need to perform some changes in packaging/develop as well. When checking this PR, please first check all of the PRs below
citusdata/packaging#945
https://msdata.visualstudio.com/Database%20Systems/_git/citus-packaging/pullrequest/817728

versions

hanefi

Please address comments before merging this

hanefi · 2022-07-27T23:06:25Z

@@ -1,5 +1,5 @@
 #
-# This file is autogenerated by pip-compile
+# This file is autogenerated by pip-compile with python 3.8


Nit, Consider introducing a .python-version file with the intended python version that should be used here.

hanefi · 2022-07-27T23:06:40Z

 wheel
 python-dotenv
 prospector[with_everything]
+setuptools==58


missing empty line at the end

hanefi · 2022-07-27T23:07:11Z

+    parser.add_argument('--input_files_dir', required=True)
+
+    args = parser.parse_args()
+    write_postgres_versions_into_file(args.input_files_dir,args.project_version)


missing empty line at the end.

hanefi · 2022-07-27T23:07:43Z

    # packages in one call
    result = stat_get_request(
-        package_list_with_pagination_request_address(PACKAGE_CLOUD_PARAMETERS, 1, 100),
+        package_list_with_pagination_request_address(PACKAGE_CLOUD_PARAMETERS, 1, 200),


Why did we need to update this?

Recently I put new packages into azure repo which exceeds 100 package . I'm using azure repo as my test repo to test the package counts. After exceed, my tests failed since some packages was outside the pagination limit.

gurkanindibay · 2022-07-26T11:19:41Z

    docker_image_name = "packaging" if not is_test else "packaging-test"
    postgres_extension = "all" if postgres_version == "all" else f"pg{postgres_version}"
    os.environ["GITHUB_TOKEN"] = github_token
+    os.environ["CONTAINER_BUILD_RUN_ENABLED"] = "true"


This parameter is required to execute the packaging image in OneBranch.
Currently packaging images directly execute fetch_build_deb script and exits. However, OneBranch first needs to download and initialize then execute the pipeline scripts inside the container
This parameter is a switch to use the packaging images both in github actions and OneBranch pipelines
If this parameter is not set, so in OneBranch container initialisation phase, image does not exit just waits
If this is set, then the script executes as regular.

gurkanindibay · 2022-07-26T11:20:54Z

        f'docker run --rm -v {input_output_parameters.output_dir}:/packages -v '
        f'{input_output_parameters.input_files_dir}:/buildfiles:ro -e '
-        f'GITHUB_TOKEN -e PACKAGE_ENCRYPTION_KEY -e UNENCRYPTED_PACKAGE '
+        f'GITHUB_TOKEN -e PACKAGE_ENCRYPTION_KEY -e UNENCRYPTED_PACKAGE -e CONTAINER_BUILD_RUN_ENABLED '


Parameter is added and set true to be able to execute build logic in fetch_and_build_deb/rpm scripts

gurkanindibay · 2022-07-26T11:23:13Z

 parameters_validation
 pathlib2
-psycopg2
+psycopg2-binary


Since out github actions main VM image is ubuntu focal, just majing this script work in ubuntu was enough
Now for OneBeanch, tools python requirements scripts shoule be executed in all supported images. In debian and centos images I got error so I needed to use binary version of psycopg2-binary

gurkanindibay · 2022-07-26T11:23:41Z

 wheel
 python-dotenv
 prospector[with_everything]
+setuptools==58


I got error in debian and centos images so I needed to fix the version of setuptools

gurkanindibay · 2022-07-26T11:24:54Z

    # packages in one call
    result = stat_get_request(
-        package_list_with_pagination_request_address(PACKAGE_CLOUD_PARAMETERS, 1, 100),
+        package_list_with_pagination_request_address(PACKAGE_CLOUD_PARAMETERS, 1, 200),


Recently, I added new files into azure repository in packagecloud so this broke my tests. I increased the number for records in page to be able to get correct result

gurkanindibay · 2022-07-26T11:27:17Z

@@ -0,0 +1,15 @@
+import argparse


In Github Actions, we validate package counts in citus_package.py without dependency for images. Since we can not execute citus_package, we needed to externalize validation logic for OneBranch build process. We call this function explicitly after fetch_and_build_deb/rpm script

gurkanindibay · 2022-07-26T11:29:50Z

@@ -0,0 +1,11 @@
+import argparse


Created because the same reason with validate_buildo_output. We execute this script just before fetch_and_build_deb/rpm to be able to get supported postgres versions

gurkanindibay added 6 commits June 28, 2022 09:04

Adds procedure to be able to write postgres

9cf8170

versions

Adds procedure to be able to validate warnings

6bc4b76

Fixes dependency problems for bionic and centos

a37166b

Adds container run enabled parameter

014bd55

Fixes parameter addition problem

b61e9f4

Fixes statistic collector tests

a8ff3b8

gurkanindibay requested review from hanefi and onurctirtir July 26, 2022 11:56

gurkanindibay mentioned this pull request Jul 26, 2022

Adds changes for one branch pipelines citusdata/packaging#945

Merged

onurctirtir approved these changes Jul 26, 2022

View reviewed changes

hanefi approved these changes Jul 27, 2022

View reviewed changes

gurkanindibay commented Jul 28, 2022

View reviewed changes

Adds empty lines

acf5f4b

gurkanindibay merged commit 1bdd130 into develop Jul 28, 2022

Conversation

gurkanindibay commented Jul 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hanefi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gurkanindibay commented Jul 25, 2022 •

edited

Loading