remove unused variable DESTDIR from uncrustify makefile#54
Merged
SaitTalhaNisanci merged 1 commit intodevelopfrom May 8, 2020
Merged
remove unused variable DESTDIR from uncrustify makefile#54SaitTalhaNisanci merged 1 commit intodevelopfrom
SaitTalhaNisanci merged 1 commit intodevelopfrom
Conversation
Member
|
What if there are some people in the team that wished to install the scripts in another path? Maybe we should ask around and see if there is any logical reasoning behind having that |
Contributor
Author
|
Well, even if there is that possibility, I dont see how it is possible with this variable because with the current code, if someone sets DESTDIR to, say, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.