Update packaging scripts to support all packages on a single branch#62
Update packaging scripts to support all packages on a single branch#62
Conversation
|
|
||
| # Based on the repo, update the package related variables | ||
| if ( $DISTRO_VERSION eq "redhat" || $DISTRO_VERSION eq "microsoft") { | ||
| if ( $DISTRO_VERSION eq "redhat" || $DISTRO_VERSION eq "microsoft" || $DISTRO_VERSION eq "all") { |
There was a problem hiding this comment.
I think we should document the allowed $DISTRO_VERSION values after we merge this.
We may either introduce some documentation like we have in citus_package
Lines 405 to 560 in 4cf2cd1
This idea may be outside the scope of this PR, just sharing my opinion
There was a problem hiding this comment.
Or before introducing that, we should at least introduce this "all" parameter to our word doc
There was a problem hiding this comment.
yeah, once we merged all the PRs I think we should update our worddoc to use the "all" parameter.
hanefi
left a comment
There was a problem hiding this comment.
LGTM with some minor comment
I am ok with introducing new envvar parameters that will be used in the CI jobs, however we need to document the changes in allowed $DISTRO_VERSION values somewhere. Preferably in Citus Packaging Documentation.
4f5a2bc to
ae4b732
Compare
ae4b732 to
8d5c08e
Compare
8d5c08e to
a20cc5a
Compare
This is needed to support: citusdata/packaging#441