Give warning for descriptions >78 instead of killing process#74
Merged
onurctirtir merged 3 commits intodevelopfrom May 11, 2020
Merged
Give warning for descriptions >78 instead of killing process#74onurctirtir merged 3 commits intodevelopfrom
onurctirtir merged 3 commits intodevelopfrom
Conversation
hanefi
reviewed
May 8, 2020
onurctirtir
force-pushed
the
warn-if-long-description
branch
from
9c48441 to
b7dfe94
Compare
hanefi
requested changes
May 11, 2020
Member
hanefi
left a comment
hanefi
left a comment
There was a problem hiding this comment.
This PR is good to go once you add some warnings to the changelog items, similar to what I suggested
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.