Skip to content

added text and startup scripts ideas - not tested yet#64

Closed
tido- wants to merge 1 commit intociur:masterfrom
tido-:master
Closed

added text and startup scripts ideas - not tested yet#64
tido- wants to merge 1 commit intociur:masterfrom
tido-:master

Conversation

@tido-
Copy link
Copy Markdown
Contributor

@tido- tido- commented Aug 11, 2020

Hi, please review.

Manual Way
************
### Quick install
Its simplicity makes SQLite extremely useful for development. It speeds up the setup of the development environment.
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part (SQL) is not relevant for installation process.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is not relevant for installation process.
@ciur , let me explain. You offer 3 different installation options. I found out via Email exchange why you use SQLite here instead of Postgre. I think it is nothing more but good practice to explain that in advance.

the gaps.

1. Within extracted directory copy ``papermerge.conf.py.example`` to ``/etc/``::
If I follow this document and still have troubles, I can open an
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is written from second person perspective - not first one.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have to jump back in the history, but I think I read both from you. I choose first one, can be 2nd. A simple change.

Now you should be able to select text
Now you should be able to select text.

## Start Papermerge at boot
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part is too specific. Start at boot of what ? These instructions would be more appropriate for specific distribution deployment (as part of that).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the idea from here https://paperless.readthedocs.io/en/latest/setup.html#making-things-a-little-more-permanent if it is already installed and running why not using it?
And as this is setup guide, why not guiding it?

@ciur
Copy link
Copy Markdown
Owner

ciur commented Aug 12, 2020

Hi Reto, I hate to say this, but I will not accept your PR. I commented along the diffs to provide you reasons why I chose to do so.

@ciur ciur closed this Aug 12, 2020
@tido-
Copy link
Copy Markdown
Contributor Author

tido- commented Aug 12, 2020

It has some stuff in it that fixes errors, that I suggest you copy the way you want it to have/be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants