Fix port_taken_on_localhost method for OSX machines #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The netstat command that was used previously was not specifically looking at LISTENING ports and was hitting false positives when there was an open connection to a remote mysql instance as well as when you had a port of like 409200 open it would fail the check for publishing port 9200 (used by elasticsearch). This lsof check will only show ports that are open and listening and is explicit to the port being checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The netstat command that was used previously was not specifically
looking at LISTENING ports and was hitting false positives when there
was an open connection to a remote mysql instance as well as when you
had a port of like 409200 open it would fail the check for publishing
port 9200 (used by elasticsearch).
This lsof check will only show ports that are open and listening and
is explicit to the port being checked.