Skip to content

History / Critic Rules

Revisions

  • R29: the PROBLEM statement is the boundary — a solution outside it needs its own PR

    @cixzhang cixzhang committed Aug 24, 2026
  • R29 calibration: count runtime decisions; size is its own signal. USAGE slot + enumerated SOLUTION in the brief

    @cixzhang cixzhang committed Aug 24, 2026
  • R29: split by decision count, not line count

    @cixzhang cixzhang committed Aug 23, 2026
  • R1j: an unjustified change is a finding even when nothing measurably breaks

    @cixzhang cixzhang committed Aug 23, 2026
  • R18e/R18f: price the render pass an effect costs; scope listeners to the moment

    @cixzhang cixzhang committed Aug 23, 2026
  • R2g: an inline names the problem and points at the pattern

    @cixzhang cixzhang committed Aug 23, 2026
  • R6e: a superseded PR's leftovers need a user, not just a difference

    @cixzhang cixzhang committed Aug 23, 2026
  • R28: walk the use case end to end — a mechanism that cannot complete it is a different feature wearing its motivation

    @cixzhang cixzhang committed Aug 23, 2026
  • R28: establish the need before the mechanism; decide the category not the instance

    @cixzhang cixzhang committed Aug 23, 2026
  • R3j: if the component can apply it, exposing it is the finding — and it found the missing start alignment

    @cixzhang cixzhang committed Aug 23, 2026
  • R16f: two halves, two verdicts, two bars — restoring a contract is not adding one

    @cixzhang cixzhang committed Aug 23, 2026
  • R18d: an effect's dep array is a claim about when it fires; resolve the chain and read it against the comment

    @cixzhang cixzhang committed Aug 23, 2026
  • R27: four tests for what the loop cannot decide, and the one-sentence handover

    @cixzhang cixzhang committed Aug 23, 2026
  • Pause R26b/R26c: the pitch pattern is unproven; R26's review-never-merge stands

    @cixzhang cixzhang committed Aug 23, 2026
  • R26c: framework-decision and pitch labels as the register the loop checks in STEP 1

    @cixzhang cixzhang committed Aug 23, 2026
  • R26b: pitch not gate, collect considerations not just code, and do not route contributors into a noisy tracker

    @cixzhang cixzhang committed Aug 23, 2026
  • R26b worked example: the layer stack lands half-adopted; six layers still off it

    @cixzhang cixzhang committed Aug 23, 2026
  • R26b: an owned integration branch turns N rulings into one design decision plus N normal reviews

    @cixzhang cixzhang committed Aug 23, 2026
  • R26: the gate is unattended merging, not merging — recommend, do not shrug

    @cixzhang cixzhang committed Aug 23, 2026
  • R26: a new subsystem is reviewed but never merged by the loop; ask the design question, not its six consequences

    @cixzhang cixzhang committed Aug 23, 2026
  • R13d: refresh a fork, never push content; ruling 3 on the edge-alignment mechanism

    @cixzhang cixzhang committed Aug 23, 2026
  • R25: public docs are for callers, not for building Astryx

    @cixzhang cixzhang committed Aug 23, 2026
  • R24: every touched PR exits in a tracked state; approved-and-blocked joins the ladder

    @cixzhang cixzhang committed Aug 23, 2026
  • R23: a cut change inherits the reasoning; it reviews itself and arms its own merge

    @cixzhang cixzhang committed Aug 23, 2026
  • R18c-cache: assert the cache, not the clock; the markdown ruling owes a perf test

    @cixzhang cixzhang committed Aug 23, 2026
  • R22 x R6b: authorship changes what an overlap means; a team draft is precedence, not a peer option

    @cixzhang cixzhang committed Aug 23, 2026
  • R22: a class is made of LANDED members; a draft settles nothing

    @cixzhang cixzhang committed Aug 23, 2026
  • What the loop is FOR: goaled on good reviews, not merges

    @cixzhang cixzhang committed Aug 23, 2026
  • R21: the gate-clearing workflow can itself be gated; an approved unblocked PR gets merged

    @cixzhang cixzhang committed Aug 23, 2026
  • R22: a feature review settles everything verifiable and hands her one question

    @cixzhang cixzhang committed Aug 23, 2026