Skip to content

History / Critic Rules

Revisions

  • R16: one presentation format for every draft — problem, solution, API, breaking, judgement

    @cixzhang cixzhang committed Aug 23, 2026
  • Scrub internal identifiers from the synced rules

    @cixzhang cixzhang committed Aug 19, 2026
  • R14d staleness + R14e anchor verification; fix contributor default, word counts, R12/R2 conflict, R2c false positive

    @cixzhang cixzhang committed Aug 19, 2026
  • Scrub: remove internal tracker command, internal source path, and a local filesystem path

    @cixzhang cixzhang committed Aug 19, 2026
  • R1g-api: hold the new API in a builder's hands before judging it

    @cixzhang cixzhang committed Aug 19, 2026
  • The principle behind R1h/R1i/R3b: walk the full experience for both audiences

    @cixzhang cixzhang committed Aug 19, 2026
  • R1i: a footgun in the builder experience blocks, even when the fix works

    @cixzhang cixzhang committed Aug 19, 2026
  • R6c: an issue on ground a team PR covers must say so; check who is already on it before dispatching

    @cixzhang cixzhang committed Aug 19, 2026
  • R15c: know what the harness owns before calling it a bug

    @cixzhang cixzhang committed Aug 19, 2026
  • R2d-git: internal names leak through git too, not just comments

    @cixzhang cixzhang committed Aug 19, 2026
  • R3b: walk the flow before you propose a fix

    @cixzhang cixzhang committed Aug 17, 2026
  • R12b: open with thanks, state findings as user impact

    @cixzhang cixzhang committed Aug 17, 2026
  • R1h: a visible regression is never a nit

    @cixzhang cixzhang committed Aug 17, 2026
  • R2g: credit travels with the work — changeset handle plus Co-authored-by

    @cixzhang cixzhang committed Aug 17, 2026
  • R2g: carrying work into another PR means getting that PR mergeable too

    @cixzhang cixzhang committed Aug 17, 2026
  • R2g: a promise in a review is filed as a knot and done in the same turn

    @cixzhang cixzhang committed Aug 17, 2026
  • R2f: cut the background; the author only needs their part

    @cixzhang cixzhang committed Aug 17, 2026
  • R2c: attribution tells the truth about who wrote it

    @cixzhang cixzhang committed Aug 17, 2026
  • R15 draft-mode clause; R1g names its R10 exception; R14c point the gate at shape claims; R1f/R7b state clean checks

    @cixzhang cixzhang committed Aug 17, 2026
  • R2e: an accidental post is worse than no post

    @cixzhang cixzhang committed Aug 17, 2026
  • R1g: for contributors, merge unless there is something you cannot live with

    @cixzhang cixzhang committed Aug 17, 2026
  • R13b: name the difference, not their defect

    @cixzhang cixzhang committed Aug 17, 2026
  • R13b: a close is ~40 words, warm, one clause of reason

    @cixzhang cixzhang committed Aug 17, 2026
  • R13b/R13c: no homework when closing someone's PR; lead with gratitude when taking one

    @cixzhang cixzhang committed Aug 17, 2026
  • R2d: nothing internal in a public comment; only kill what you started

    @cixzhang cixzhang committed Aug 17, 2026
  • R6b: team system-level solution takes precedence; R15b: cover every layer type

    @cixzhang cixzhang committed Aug 17, 2026
  • R14b: a new rule or gate must show its catch, and whether it was real

    @cixzhang cixzhang committed Aug 17, 2026
  • R1f: the commit type is a risk claim, check it against the diff

    @cixzhang cixzhang committed Aug 17, 2026
  • R7b: anywhere drift is possible, look harder

    @cixzhang cixzhang committed Aug 17, 2026
  • R15: layout frames must ship, not just be captured

    @cixzhang cixzhang committed Aug 17, 2026