Skip to content

History / Reviewer Brief

Revisions

  • brief: n/a escape hatch for unreachable slots, 7d as an early hypothesis, async-source evidence rule, collaborator bucket, doc'd? column

    @cixzhang cixzhang committed Aug 24, 2026
  • R34: file findings against the cause and size them by outcome; JUDGEMENT reads slot bodies, not labels; a11y defects BLOCK

    @cixzhang cixzhang committed Aug 24, 2026
  • T4b: theme target names derive as <component-kebab>-<part>; establish frozen-vs-unreleased before asking for a rename

    @cixzhang cixzhang committed Aug 24, 2026
  • API absorbs USAGE — call site first, then the table, then ossification

    @cixzhang cixzhang committed Aug 24, 2026
  • API: enumerate as a table — change, public, class, per-row verdict

    @cixzhang cixzhang committed Aug 24, 2026
  • SOLUTION: a holistic design pass is one decision; behaviour and new API still split out

    @cixzhang cixzhang committed Aug 24, 2026
  • JUDGEMENT: four verdicts in priority order — comment only when problem/solution/impact are unclear

    @cixzhang cixzhang committed Aug 24, 2026
  • put the VERDICT line in every slot of the output template, not just the convention note

    @cixzhang cixzhang committed Aug 24, 2026
  • PERFORMANCE: the evidence a perf block must carry — counts not clocks, both builds one run, multiple N, banked repro

    @cixzhang cixzhang committed Aug 24, 2026
  • every slot ends in a VERDICT line; JUDGEMENT curates them instead of re-deriving

    @cixzhang cixzhang committed Aug 24, 2026
  • PERFORMANCE: a measured degradation is request-changes, not a tradeoff note

    @cixzhang cixzhang committed Aug 24, 2026
  • A11Y & I18N is its own slot, wired to rubric section 1 and section 9

    @cixzhang cixzhang committed Aug 24, 2026
  • VISUAL EVIDENCE: label every difference intentional or not; intentional cites the PR's problem, Design Conventions or rubric §5

    @cixzhang cixzhang committed Aug 24, 2026
  • ossification: a new concept is marked [Needs human judgement], not argued

    @cixzhang cixzhang committed Aug 24, 2026
  • ossification: ask who else has this problem and what they called it

    @cixzhang cixzhang committed Aug 24, 2026
  • scatter the audit rubric across the template: §3 in API, §2 in THEMING, §1+§9 rendered in VISUAL EVIDENCE, §4+§9 source in BREAKING

    @cixzhang cixzhang committed Aug 24, 2026
  • API absorbs ossification — answered per enumerated line, not per PR

    @cixzhang cixzhang committed Aug 24, 2026
  • JUDGEMENT: name which half needs a human — design owner stands in for design, never for API

    @cixzhang cixzhang committed Aug 24, 2026
  • STEP 5b: grep the siblings before writing a convention finding; R31: merge prose is not a trailer; R32: green CI is not evidence CI ran

    @cixzhang cixzhang committed Aug 24, 2026
  • R3l: design/API judgement calls have wiki pages; BREAKING gains behaviour, PERFORMANCE gains effects, THEME TARGETS renamed THEMING

    @cixzhang cixzhang committed Aug 24, 2026
  • VISUAL EVIDENCE absorbs the render matrix — it posts with the review, not as a second comment

    @cixzhang cixzhang committed Aug 24, 2026
  • kit is the source of truth; every change propagates to this wiki in the same turn

    @cixzhang cixzhang committed Aug 24, 2026
  • IMPACT: convert the measurement to the experience, or say you could not

    @cixzhang cixzhang committed Aug 24, 2026
  • IMPACT: always frame it as what a person experiences

    @cixzhang cixzhang committed Aug 24, 2026
  • IMPACT: say what merging newly exposes, not just who it reaches

    @cixzhang cixzhang committed Aug 24, 2026
  • STEP 7c2: grep the diff for the fix you are about to ask for; R1e becomes a gate

    @cixzhang cixzhang committed Aug 24, 2026
  • R1g: changed meaning and wrong mechanism are exceptions too; R30 cites the working sibling

    @cixzhang cixzhang committed Aug 24, 2026
  • R30: find the interaction decision the findings are children of

    @cixzhang cixzhang committed Aug 24, 2026
  • STEP 7: the three checks the critic keeps failing; stock spawn prompt

    @cixzhang cixzhang committed Aug 24, 2026
  • R29: plural problems are fine; unrecorded ones are the failure

    @cixzhang cixzhang committed Aug 24, 2026